Repository navigation
Remove hard-coded sigmoid for voting ensemble method in Auto3DSeg - #5734
Merged
Merged
Conversation
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Contributor
|
is it ready? or you plan to add more updates? @mingxin-zheng |
Collaborator
Author
wyli
approved these changes
Dec 14, 2022
Contributor
|
/build |
wyli
enabled auto-merge (squash)
December 14, 2022 10:04
wyli
disabled auto-merge
December 14, 2022 10:12
Contributor
|
/build |
wyli
enabled auto-merge (squash)
December 14, 2022 10:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mingxin Zheng 18563433+mingxin-zheng@users.noreply.github.com
Fixes item 3 and 5 in #5564.
Description
The
votemethod inensemble_predcurrently does not work for under sigmoid mode, because the function overrides the argument to False before theVoteEnsemble.Also, if the user only trains a small number of algorithm (1 fold for 1 algo) and forgets the update the
n_best(default is 5) inAlgoEnsembleBestN, instead of throwing an error, the fix will automatically use all available algos after posting a warning.Types of changes
./runtests.sh -f -u --net --coverage.