Skip to content

Remove hard-coded sigmoid for voting ensemble method in Auto3DSeg - #5734

Merged
wyli merged 5 commits into
Project-MONAI:devfrom
mingxin-zheng:fix-5564-3
Dec 14, 2022
Merged

wyli merged 5 commits into
Project-MONAI:devfrom
mingxin-zheng:fix-5564-3

Conversation

@mingxin-zheng

@mingxin-zheng mingxin-zheng commented Dec 14, 2022 •

Copy link
Copy Markdown
Collaborator

Signed-off-by: Mingxin Zheng 18563433+mingxin-zheng@users.noreply.github.com

Fixes item 3 and 5 in #5564.

Description

The vote method in ensemble_pred currently does not work for under sigmoid mode, because the function overrides the argument to False before the VoteEnsemble.

Also, if the user only trains a small number of algorithm (1 fold for 1 algo) and forgets the update the n_best (default is 5) in AlgoEnsembleBestN , instead of throwing an error, the fix will automatically use all available algos after posting a warning.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.

Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
Signed-off-by: Mingxin Zheng <18563433+mingxin-zheng@users.noreply.github.com>
@wyli

wyli commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

is it ready? or you plan to add more updates? @mingxin-zheng

@mingxin-zheng

Copy link
Copy Markdown
Collaborator Author

Hi @wyli , this PR is ready.

Originally, I was going to address the comment 5 in 5564 in another PR, but the change is so minor that I decided to append that to this PR.

The other items in #5564 are for enhancement. I have no plan to make more changes from my side before 1.1 release.

@wyli

wyli commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) December 14, 2022 10:04
@wyli
wyli disabled auto-merge December 14, 2022 10:12
@wyli

wyli commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) December 14, 2022 10:15
@wyli
wyli merged commit 469b146 into Project-MONAI:dev Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants