Skip to content

Make RandTorchVisiond and RandCuCIMd Consistent - #5569

Merged
wyli merged 19 commits into
Project-MONAI:devfrom
bhashemian:update-rand-wrappers
Dec 7, 2022
Merged

wyli merged 19 commits into
Project-MONAI:devfrom
bhashemian:update-rand-wrappers

Conversation

@bhashemian

Copy link
Copy Markdown
Member

Description

Both RandTorchVisiond and RandCuCIMd are dealing with the third-party libraries and they should have the same API, especially on using apply_prob instead of prob since it is different than the prob of the underlying randomized tranform.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian reopened this Nov 23, 2022
Comment thread monai/transforms/utility/dictionary.py Resolved
@SachidanandAlle

Copy link
Copy Markdown
Contributor

I agree on that naming part.. let it consistent across all other transforms unless prob field is already taken by some torch vision function (as we r passing kwargs)

@SachidanandAlle
SachidanandAlle dismissed their stale review November 28, 2022 03:18

Logically looks ok to me.. I will let others to decide on standard convention and approve

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@wyli

wyli commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) December 5, 2022 22:06
Comment thread monai/data/test_time_augmentation.py Resolved
bhashemian and others added 2 commits December 7, 2022 11:04
Co-authored-by: Wenqi Li <831580+wyli@users.noreply.github.com>
@wyli

wyli commented Dec 7, 2022 •

Copy link
Copy Markdown
Contributor

/black

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@wyli
wyli disabled auto-merge December 7, 2022 16:18
monai-bot and others added 2 commits December 7, 2022 18:15
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@wyli

wyli commented Dec 7, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli merged commit 3873d23 into Project-MONAI:dev Dec 7, 2022
@bhashemian
bhashemian deleted the update-rand-wrappers branch December 7, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants