Skip to content

Fix metadata integration test - #534

Merged
ericspod merged 4 commits into
masterfrom
fix-metadata-integration-test
Jun 11, 2020
Merged

ericspod merged 4 commits into
masterfrom
fix-metadata-integration-test

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jun 11, 2020 •

Copy link
Copy Markdown
Contributor

Description

This PR fixed CI test issue of integration.

The root cause is that:
The previous test program only copied affine and filename_or_obj to NiftiSaver and default value of resample is True.
Now we copied all the metadata to NiftiSaver(including original_affine and spatial_shape), so the resampled result is different.
I updated the expected output values.

Status

Ready

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@Nic-Ma Nic-Ma mentioned this pull request Jun 11, 2020
3 tasks done
@Nic-Ma

Nic-Ma commented Jun 11, 2020

Copy link
Copy Markdown
Contributor Author

Integration tests passed in our CI, change back to disable integration tests for this branch.

@Nic-Ma Nic-Ma changed the title [WIP] Fix metadata integration test Fix metadata integration test Jun 11, 2020
@Nic-Ma
Nic-Ma requested review from atbenmurray, ericspod and wyli June 11, 2020 03:40
@ericspod
ericspod merged commit 0d25541 into master Jun 11, 2020
@wyli
wyli deleted the fix-metadata-integration-test branch June 11, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants