Skip to content

gradient based saliency - #4236

Merged
wyli merged 17 commits into
Project-MONAI:devfrom
rijobro:gradient_based_saliency
May 11, 2022
Merged

wyli merged 17 commits into
Project-MONAI:devfrom
rijobro:gradient_based_saliency

Conversation

@rijobro

@rijobro rijobro commented May 6, 2022

Copy link
Copy Markdown
Contributor

Adds VanillaGrad, SmoothGrad and guided backprop versions of both of these, inspired by https://github.com/pikahhh/pytorch-smoothgrad.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

image

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
rijobro requested review from Nic-Ma, ericspod and wyli May 6, 2022 10:00
@rijobro

rijobro commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

Examples with dogs and cats tutorial

image

@rijobro rijobro mentioned this pull request May 6, 2022
1 task done
rijobro and others added 5 commits May 6, 2022 12:18
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@ericspod

ericspod commented May 6, 2022

Copy link
Copy Markdown
Member

We should have docstrings for these definitions. The module replacer decorator looks like a useful general purpose idea that could be generalised and put somewhere as a utility.

Comment thread monai/visualize/gradient_based.py Resolved
rijobro added 2 commits May 9, 2022 09:33
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro mentioned this pull request May 9, 2022
6 tasks done
rijobro added 2 commits May 9, 2022 16:20
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@wyli wyli mentioned this pull request May 10, 2022
5 tasks done
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli and others added 5 commits May 11, 2022 14:44
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
reuse modelwithhooks in `monai/visualize/gradient_based.py`
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified with the unit tests and the notebook examples

@wyli

wyli commented May 11, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli
wyli enabled auto-merge (squash) May 11, 2022 16:45
@wyli
wyli merged commit 0bbeb1e into Project-MONAI:dev May 11, 2022
@rijobro
rijobro deleted the gradient_based_saliency branch May 19, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants