Repository navigation
81 layer factory - #127
Merged
Merged
81 layer factory#127
Conversation
Nic-Ma
reviewed
Feb 29, 2020
Nic-Ma
reviewed
Feb 29, 2020
Nic-Ma
reviewed
Feb 29, 2020
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Add several inline comments.
Others look good to me.
And we need a clear document to introduce how to use APIs to develop networks.
Otherwise, other contributors may feel hard to add new networks.
Thanks.
Member
Author
|
I've finally had a chance to get back to this with updates and changes to DenseNet. |
Nic-Ma
approved these changes
Mar 27, 2020
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
- Suggest listing all the supported layer types in the doc-string of layer factory, otherwise, users need to check the code details for that layer type name(like Pool. ADAPTIVEAVG).
- And I created another PR #217 for this PR to introduce the layer factory in MONAI highlights.
Could you please help review it?
Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81.
Description
Adds a new layer factory mechanism which is extensible and more generic.
Status
Work in progress
Types of changes