Skip to content

81 layer factory - #127

Merged
wyli merged 15 commits into
masterfrom
81-layer-factory
Mar 27, 2020
Merged

wyli merged 15 commits into
masterfrom
81-layer-factory

Conversation

@ericspod

Copy link
Copy Markdown
Member

Fixes #81.

Description

Adds a new layer factory mechanism which is extensible and more generic.

Status

Work in progress

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or new feature that would cause existing functionality to change)
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@ericspod
ericspod requested review from atbenmurray and wyli February 28, 2020 14:16
Comment thread monai/networks/layers/factories.py Resolved
Comment thread monai/networks/layers/factories.py Resolved

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add several inline comments.
Others look good to me.
And we need a clear document to introduce how to use APIs to develop networks.
Otherwise, other contributors may feel hard to add new networks.
Thanks.

@ericspod

Copy link
Copy Markdown
Member Author

I've finally had a chance to get back to this with updates and changes to DenseNet.

@ericspod
ericspod requested a review from Nic-Ma March 26, 2020 14:01

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

  1. Suggest listing all the supported layer types in the doc-string of layer factory, otherwise, users need to check the code details for that layer type name(like Pool. ADAPTIVEAVG).
  2. And I created another PR #217 for this PR to introduce the layer factory in MONAI highlights.
    Could you please help review it?

Thanks.

@wyli
wyli merged commit e657db0 into master Mar 27, 2020
@wyli
wyli deleted the 81-layer-factory branch May 21, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create layer factory mechanism

3 participants