Skip to content

89 port highresnet - #119

Merged
wyli merged 1 commit into
masterfrom
89-port-highresnet
Feb 26, 2020
Merged

wyli merged 1 commit into
masterfrom
89-port-highresnet

Conversation

@wyli

@wyli wyli commented Feb 26, 2020

Copy link
Copy Markdown
Contributor

Fixes #89.

Description

highresnet and its shape tests for spatial 1d/2d/3d

Status

Ready

Types of changes

  • non-breaking new feature
  • New tests added to cover the changes
  • Docstrings/Documentation updated

@wyli wyli added this to the implement reference networks milestone Feb 26, 2020
@wyli
wyli requested review from ericspod and fepegar February 26, 2020 10:26
SUPPORTED_NORM = {
'batch': lambda spatial_dims: get_normalize_type(spatial_dims, is_instance=False),
'instance': lambda spatial_dims: get_normalize_type(spatial_dims, is_instance=True),
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for #81 would be great to have a factory to support group norm as well. @ericspod

@fepegar fepegar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM.

Why are only 'relu'|'prelu'|'relu6' allowed?

@wyli

wyli commented Feb 26, 2020 •

Copy link
Copy Markdown
Contributor Author

Nice! LGTM.

Why are only 'relu'|'prelu'|'relu6' allowed?

just to keep the readability...having the fancy choices means we'll add more if else conditions such as selu doesn't need additional feature normalisation, leakyrelu prefers some specific nn.init for the convolutions

@wyli
wyli merged commit 822d568 into master Feb 26, 2020
@wyli wyli removed this from the implement reference networks milestone Feb 26, 2020
@wyli
wyli deleted the 89-port-highresnet branch April 6, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port highresnet

3 participants