Skip to content

Support newer openslide-python version that has available whls for newer python versions #7335

Closed

Description

@jamesobutler

Is your feature request related to a problem? Please describe.
Users installing monai on Python 3.11+ run into issues with the openslide-python version that is strictly specified as 1.1.2. This version of openslide-python was released in September 2020 (over 3 years ago) and only has whls on PyPI up to python 3.10 (see here).

A user running Python 3.11 for instance runs into it trying to build openslide-python 1.1.2 from source and the build fails either due to missing dependencies or possible lack of compatibility.

openslide-python==1.1.2

Describe the solution you'd like
Support a newer version of openslide-python to improve support of monai on newer versions of python. The latest version of openslide-python is currently 1.3.1 released in October 2023. It has available whl files on PyPI for Python 3.8-3.12 (see here).

Describe alternatives you've considered
Removing the openslide-python dependency entirely from monai could also avoid errors when pip install monai on newer python versions.

Or reduce functionality for certain python versions such that it is only installed for Python versions that have whl files available.

openslide-python==1.1.2;python_version<"3.11"

Activity

  1. jamesobutler commented on Dec 20, 2023

    @jamesobutler
    ContributorAuthor

    Once Python 3.11+ support for monai is working, then the information about supported python versions can be updated in the following place below and be indicated on the https://pypi.org/project/monai/ page.

    MONAI/setup.cfg

    Lines 23 to 26 in 90d2acb

    Programming Language :: Python :: 3
    Programming Language :: Python :: 3.8
    Programming Language :: Python :: 3.9
    Programming Language :: Python :: 3.10

  2. added a commit that references this issue on Dec 28, 2023
    b92baf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions