You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Follow up of #4050,
this is a feature request to extend the surface-based metric module for 3D, with the support of more detailed quantizations when computing local surface lengths/areas (such as the computation proposed in https://github.com/deepmind/surface-distance).
the way 3D surfaces & surface distances are handled in deep mind is different from MONAI: Instead of defining surfaces at surface voxel boundaries, surface points are located on a grid that is shifted by half of the grid spacing along each axis (cf. Fig. 10 in their paper):
I think it should be discussed more broadly whether to keep the surface computation currently used in MONAI, or to switch to the deep mind computation, or to establish a switch such that the user can decide on the computation. This choice should be made consistently for all boundary-overlap metrics.
Hausdorff distance and Average surface distance in Monai are already implemented using the deep mind library you are referring to, what exactly is not present that you need?
You can also lok into some fast approximation that I am now developing in
Hi can Average surface distance be considered same as Average Hausdorff distance ? Because I cant see Average Hausdorff distance implementation in monai. Thanks for reply
Hello I can not say wheather they are mathemathically the same as my mathemathical skills are not sufficient - I suppose not exactly, but I ran some statistical experiments suggesting that they are closely correlated - correlation around 0.9 and very low p values.
Hovewer this is fast morphological approximation - quite accurate and having very good performance, still not exact, also it can be considered rather research than production software
To be honest recently I got a new job and was unable to spend time debugging MONAI pull request here is the pull request to MONAI - it is not working, would you like to contribute in debugging :) #4078
Activity
[-]extensions of surface Dice metric[/-][+]extensions of the surface-based metric[/+]jakubMitura14 commentedon Apr 13, 2022
Hausdorff distance and Average surface distance in Monai are already implemented using the deep mind library you are referring to, what exactly is not present that you need?
You can also lok into some fast approximation that I am now developing in
#4078
this can give potentially the performant approximations of the quantities you are requesting
wyli commentedon Apr 13, 2022
please see #4050 (comment)
jakubMitura14 commentedon Apr 13, 2022
ok now I get it, I will consider wheather I can contribute to it !
hreso110100 commentedon Jun 12, 2022
Hi can Average surface distance be considered same as Average Hausdorff distance ? Because I cant see Average Hausdorff distance implementation in monai. Thanks for reply
jakubMitura14 commentedon Jun 12, 2022
Hello I can not say wheather they are mathemathically the same as my mathemathical skills are not sufficient - I suppose not exactly, but I ran some statistical experiments suggesting that they are closely correlated - correlation around 0.9 and very low p values.
hreso110100 commentedon Jun 23, 2022
Maybe @wyli can confirm this ?
wyli commentedon Jun 23, 2022
no they are different distances @hreso110100
hreso110100 commentedon Jun 26, 2022
And is there some plan to add also this metric ?
jakubMitura14 commentedon Jun 26, 2022
Here is working Morphological algorithm (pytorch extension - not MONAI)
https://github.com/jakubMitura14/Hausdorff_morphological
Hovewer this is fast morphological approximation - quite accurate and having very good performance, still not exact, also it can be considered rather research than production software
To be honest recently I got a new job and was unable to spend time debugging MONAI pull request here is the pull request to MONAI - it is not working, would you like to contribute in debugging :)
#4078
extend SurfaceDiceMetric for 3D images (#6549)
4103 enhances surface Dice to use subvoxel borders (Project-MONAI#6681)