Skip to content

extensions of the surface-based metric #4103

Closed

Description

@wyli

Is your feature request related to a problem? Please describe.
Follow up of #4050,
this is a feature request to extend the surface-based metric module for 3D, with the support of more detailed quantizations when computing local surface lengths/areas (such as the computation proposed in https://github.com/deepmind/surface-distance).

#4050 (comment)

the way 3D surfaces & surface distances are handled in deep mind is different from MONAI: Instead of defining surfaces at surface voxel boundaries, surface points are located on a grid that is shifted by half of the grid spacing along each axis (cf. Fig. 10 in their paper):

grafik

I think it should be discussed more broadly whether to keep the surface computation currently used in MONAI, or to switch to the deep mind computation, or to establish a switch such that the user can decide on the computation. This choice should be made consistently for all boundary-overlap metrics.

cc @SilviaSeidlitz

Activity

  1. changed the title [-]extensions of surface Dice metric[/-] [+]extensions of the surface-based metric[/+] on Apr 11, 2022
  2. jakubMitura14 commented on Apr 13, 2022

    @jakubMitura14

    Hausdorff distance and Average surface distance in Monai are already implemented using the deep mind library you are referring to, what exactly is not present that you need?

    You can also lok into some fast approximation that I am now developing in

    #4078

    this can give potentially the performant approximations of the quantities you are requesting

  3. wyli commented on Apr 13, 2022

    @wyli
    ContributorAuthor

    what exactly is not present that you need?

    please see #4050 (comment)

  4. jakubMitura14 commented on Apr 13, 2022

    @jakubMitura14

    ok now I get it, I will consider wheather I can contribute to it !

  5. hreso110100 commented on Jun 12, 2022

    @hreso110100

    Hi can Average surface distance be considered same as Average Hausdorff distance ? Because I cant see Average Hausdorff distance implementation in monai. Thanks for reply

  6. jakubMitura14 commented on Jun 12, 2022

    @jakubMitura14

    Hello I can not say wheather they are mathemathically the same as my mathemathical skills are not sufficient - I suppose not exactly, but I ran some statistical experiments suggesting that they are closely correlated - correlation around 0.9 and very low p values.

  7. hreso110100 commented on Jun 23, 2022

    @hreso110100

    Maybe @wyli can confirm this ?

  8. wyli commented on Jun 23, 2022

    @wyli
    ContributorAuthor

    no they are different distances @hreso110100

  9. hreso110100 commented on Jun 26, 2022

    @hreso110100

    And is there some plan to add also this metric ?

  10. jakubMitura14 commented on Jun 26, 2022

    @jakubMitura14

    Here is working Morphological algorithm (pytorch extension - not MONAI)
    https://github.com/jakubMitura14/Hausdorff_morphological

    Hovewer this is fast morphological approximation - quite accurate and having very good performance, still not exact, also it can be considered rather research than production software

    To be honest recently I got a new job and was unable to spend time debugging MONAI pull request here is the pull request to MONAI - it is not working, would you like to contribute in debugging :)
    #4078

  11. added a commit that references this issue on Jul 5, 2023
    922b11e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions