Skip to content
This repository was archived by the owner on Feb 7, 2025. It is now read-only.
This repository was archived by the owner on Feb 7, 2025. It is now read-only.

Unused projection layer in AttentionBlock #503

Open

Description

@ChristianHinge

After wrapping a MONAI AutoencoderKL model in pytorch lightning, I got an error regarding an unused parameter in the custom AttentionBlock implementation.

diffusion_model_unet.py and autoencoderkl.py line 233:

self.proj_attn = nn.Linear(num_channels, num_channels)

To me, it looks like this layers is completely unused. I cannot tell whether it is a mistake that this parameter is unsued, or if it should have never been defined in the first place.

Activity

  1. virginiafdez commented on Oct 25, 2024

    @virginiafdez
    Contributor

    Hello,

    Apologies for the delay.
    This repository is going to be archived, as it has all been integrated into MONAI Core (https://github.com/Project-MONAI/MONAI).
    I believe this issue has been addressed during the porting.
    Could you check by using the latest MONAI version incorporating the generative functions? If the issue persists there, please do open an Issue in MONAI Core and we will have a look as soon as possible.

    Thank you very much!

    Virginia

  2. self-assigned this
    on Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions