You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
FOUR-33661: Hide editing actions for Collection Record Lists - #1943
Enable Editable on a Variable Record List, then switch its source to Collection. Preview still shows Add and row editing actions because the previous editable setting is kept.
Solution
Set editable to false when switching to Collection.
Show Add, Edit, Delete, and their modals only for editable Variable lists.
Treat a missing or null source option as Variable so older saved screens remain editable.
Add Classic and Modern regression tests for legacy settings and Collection lists with stale editable values.
How to Test
RecordListSource.spec.js: 31 tests passed with a Jest/Vue compatibility adapter.
Classic and Modern smoke tests passed: lists saved without source show Add, Edit, and Delete, and row edits can be saved.
Collection lists show no editing actions even when saved with editable set to true.
These results remain correct after saving and refreshing the screen.
Please disregard the failing checks on this PR. The SonarQube findings concern prop type declarations in the existing Vue 2 component, while the PHPUnit failures also occur on other Screen Builder PRs. The CircleCI failure remains unexplained and has not been linked to these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
Enable Editable on a Variable Record List, then switch its source to Collection. Preview still shows Add and row editing actions because the previous editable setting is kept.
Solution
How to Test
Related Tickets & Packages