Skip to content

fix(FOUR-34444): restore V1_1 TaskController instantiation for web en… - #9173

Open
gproly wants to merge 1 commit into
developfrom
bugfix/FOUR-34444
Open

gproly wants to merge 1 commit into
developfrom
bugfix/FOUR-34444

Conversation

@gproly

@gproly gproly commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

…try getTaskScreen

Remove required constructor injection so package-webentry can call showScreen via new TaskControllerV1_1(). Resolve TaskCompletionRawService from the container only in update().

https://processmaker.atlassian.net/browse/FOUR-34444

ci:deploy
ci:run-testbench

…try getTaskScreen

Remove required constructor injection so package-webentry can call showScreen
via `new TaskControllerV1_1()`. Resolve TaskCompletionRawService from the
container only in update().

https://processmaker.atlassian.net/browse/FOUR-34444
@cursor

cursor Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Localized controller wiring change; completion logic still uses the same service, only resolved lazily in update().

Overview
Fixes web-entry getTaskScreen by dropping required constructor injection on the V1_1 TaskController, so callers can use new TaskController() (e.g. for showScreen) without Laravel resolving dependencies.

Task completion in update() is unchanged in behavior: it now resolves TaskCompletionRawService from the container at call time via app(TaskCompletionRawService::class) instead of a constructor-promoted property.

Reviewed by Cursor Bugbot for commit fc39585. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants