Repository navigation
fix(FOUR-34432): server error when completing a request - #9171
Open
rodriquelca wants to merge 1 commit into
Open
rodriquelca wants to merge 1 commit into
rodriquelca wants to merge 1 commit into
Conversation
gproly
approved these changes
Nov 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue & Reproduction Steps
TokenPersistenceRawRepository called json_encode() on data, token_properties, and self_service_groups from getAttributes(). Eloquent’s array cast already stores JSON strings there, so values were double-encoded and read back as strings instead of arrays.
Solution
completed_request_issue.mov
How to Test
Setup: Set TOKEN_PERSISTENCE_RAW_ENABLED=true in .env, then reload config (e.g. php artisan config:clear if you use config cache).
Complete a task with form data
Start a process with a form, fill fields, submit/complete the task.
Re-open the task or request summary: field values should display normally (not empty or garbled).
Request data after steps
Run a multi-step process; complete at least one task.
Open the request: variables from earlier steps should still be there for later tasks/screens.
Self-service (optional)
Run a self-service task that sets groups/users.
Confirm it appears in the right inbox/pool and can be claimed without errors.
Unit test
./vendor/bin/phpunit tests/unit/ProcessMaker/Repositories/TokenPersistenceRawRepositoryTest.php
Related Tickets & Packages
Code Review Checklist