Skip to content

Task/FOUR-34405: Persist screen input data for preview and create data scenarios list - #9168

Merged
caleeli merged 1 commit into
feature/FOUR-34328from
task/FOUR-34405
Nov 13, 2026
Merged

caleeli merged 1 commit into
feature/FOUR-34328from
task/FOUR-34405

Conversation

@agustinbusso

@agustinbusso agustinbusso commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Refine PM4 screen guidance to require branch-specific, visibly distinct Preview presets and verify Public Files URLs before using them. Document avoiding silent URL rewrites and large asset imports, with related verification and checklist updates.

Screen.Recording.2026-11-13.at.5.21.19.PM.mov

Related tickets and PRs

https://processmaker.atlassian.net/browse/FOUR-34405

Persist named preview data presets for screens and versions, expose them through the screen API and MCP tools, and add Screen Builder controls to create, edit, reorder, apply, and update presets.
@cursor

cursor Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches screen draft/version persistence and designer save paths with a new stored JSON format; low security impact but regressions could affect screen editing and MCP screen updates.

Overview
Adds preview_presets so designers can save, reorder, and apply named JSON preview payloads alongside draft/publish autosave. A migration and model/version casts persist the list; each preset stores data as a JSON string so empty objects are not lost through PHP decoding.

Screen Builder’s Data Input panel now exposes preset CRUD, selection, dirty-state update/discard, and drag-to-reorder, wiring preview_presets into draft and publish API calls. MCP screen tools, ScreenCatalog normalization, and agent guidance are updated to accept and document the new field.

Reviewed by Cursor Bugbot for commit 0890c34. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0890c34. Configure here.

},
onPreviewPresetsReorder() {
this.persistPreviewPresets();
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reorder desyncs selected preset

Medium Severity

Dragging presets reorders previewPresets but leaves activePreviewPresetIndex pointing at the old slot. The radio stays on a different scenario, and Update writes the current JSON into the wrong preset. List items also use the array index as :key, so Vue can reuse the wrong row after a drag. Removing a preset has the same index problem for an open edit card via previewPresetEditIndex.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0890c34. Configure here.

@cursor
cursor Bot requested review from caleeli and eiresendez November 13, 2026 20:40
@eiresendez
eiresendez removed their request for review November 13, 2026 21:14
@caleeli
caleeli merged commit 8cd1706 into feature/FOUR-34328 Nov 13, 2026
13 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants