Repository navigation
feat(FOUR-34380):Subprocess Inline to group task to reduce the visualizacion of BPMN - FE - #9163
Conversation
…izacion of BPMN - FE
PR SummaryMedium Risk Overview sendTask → scriptTask conversion in ConvertBPMNTest::testConvertSubProcess now asserts a single process row, Reviewed by Cursor Bugbot for commit 705f2fa. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 705f2fa. Configure here.
| ]; | ||
| } | ||
| if ($conversions) { | ||
| $this->ensurePmNamespaceOnDefinitions($document); |
There was a problem hiding this comment.
Embedded subprocess remains non-executable
High Severity
Removing the subProcess to callActivity rewrite leaves embedded bpmn:subProcess in stored BPMN, but runtime still only implements subprocess via callActivity. WorkflowServiceProvider never maps subProcess, DefinitionsRepository has no subprocess factory, and unimplemented elements are skipped. Tokens that hit an inline subProcess can stall, skip inner tasks, or fail after save, so grouped processes will not run the way converted child processes did.
Reviewed by Cursor Bugbot for commit 705f2fa. Configure here.
|







Issue & Reproduction Steps
On every process save, convertFromExternalBPM() turned embedded bpmn:subProcess into callActivity, created a child process, and rewrote the BPMN. That broke the expected XML and could break the modeler after reload (e.g. missing pm:config).
Reproduce: Open modeler with BPMN containing subProcess → Save → Check stored BPMN or process count (element becomes callActivity, extra process row). Fixture: tests/Feature/Api/processes/CP.01.00 Create new customer.bpmn.
Solution
How to Test
Manual: save a process with bpmn:subProcess; confirm XML still has subProcess, no new child process, and F5/modeler behaves as expected.
Related Tickets & Packages
Code Review Checklist