Skip to content

Task/FOUR-23810: [44667] Ellucian - Issue with number of screens shown in Forms tab under request - #9158

Open
CarliPinell wants to merge 2 commits into
developfrom
task/FOUR-23810
Open

CarliPinell wants to merge 2 commits into
developfrom
task/FOUR-23810

Conversation

@CarliPinell

@CarliPinell CarliPinell commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Solution

  • Method screenRequested in "ProcessRequestController.php" was enhanced to show correctly "Screen" counter in /requests FORMS tab paginator
  • Test base on use case reported on ticket was added

How to Test

  • Reproduce the steps mentioned on ticket

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

@cursor

cursor Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes which tokens count toward Forms tab pagination; semantics were preserved in code comments but edge cases (empty screenRef, web entry) could differ from the old post-filter behavior.

Overview
Fixes incorrect Forms tab counters on request detail by filtering screenRequested at query time instead of dropping rows after pagination.

screenRequested now resolves BPMN element_ids that actually have a configured screen (screenRef or web entry screen_id) via elementIdsWithRequestedScreen / tokenHasRequestedScreen, then applies whereIn('element_id', …) so meta.total and pages only reflect task (and other screened) submissions—not extra startEvent, gateway, or other tokens without forms.

A feature test reproduces an exclusive-gateway loop where totals previously showed e.g. “1–3 of 6” and now correctly report 3 screened items.

Reviewed by Cursor Bugbot for commit 3e65bbe. Bugbot is set up for automated code reviews on this repo. Configure here.

@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://tenant-1.ci-e22f4c27d6.engk8s.processmaker.net

@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants