Skip to content

Auto layout (poc not merge) - #9155

Open
rodriquelca wants to merge 1 commit into
feature/FOUR-34328from
autoLayout
Open

rodriquelca wants to merge 1 commit into
feature/FOUR-34328from
autoLayout

Conversation

@rodriquelca

Copy link
Copy Markdown
Contributor

Require each sequenceFlow to have a bpmndi:BPMNEdge with at least two di:waypoint (missing_bpmn_edge / incomplete_bpmn_edge).
On create-process / update-process, run layout when DI is incomplete even if auto_layout_bpmn is false (when layout is enabled in config).
Update MCP server instructions, skills, and tests (unit + Node feature test).

image

@cursor

cursor Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches BPMN save/deploy paths and spawns an external Node process for layout; new MCP tools perform authorized create/update operations on core assets.

Overview
BPMN diagram interchange and auto-layout — MCP process create/update now treats missing or broken sequence-flow diagram info as a first-class problem. ProcessBpmnValidator fails validation when a sequenceFlow has no bpmndi:BPMNEdge or fewer than two di:waypoint entries (missing_bpmn_edge / incomplete_bpmn_edge), and exposes lacksSequenceFlowDiagramInterchange for callers. ProcessCatalog runs BpmnLayoutService (external Node layout script when mcp.bpmn_layout.enabled) on create/update when the user opts in via auto_layout_bpmn (default true) or when interchange is incomplete—even if auto_layout_bpmn is false—so Modeler no longer shows spider connectors from (0,0). A dedicated layout-bpmn tool and updated Process MCP instructions/skills document the behavior.

The same changeset also wires this into a broader Model Context Protocol surface: Process, Screen, and Data Connectors MCP servers with catalogs, validators, guidance/skills resources, and CRUD-style tools for processes (including plan-process and BPMN validation), screens, data connectors, and collections.

Reviewed by Cursor Bugbot for commit 4b53c1b. Bugbot is set up for automated code reviews on this repo. Configure here.

@rodriquelca
rodriquelca changed the base branch from develop to feature/FOUR-34328 November 11, 2026 14:33
@rodriquelca
rodriquelca requested a review from caleeli November 11, 2026 15:09
@rodriquelca rodriquelca changed the title Auto layout Auto layout (poc) Nov 11, 2026
@rodriquelca rodriquelca changed the title Auto layout (poc) Auto layout (poc not merge) Nov 11, 2026
@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
B Security Rating on New Code (required ≥ A)
2 New Maintainability Issues (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant