Repository navigation
Feature/plugins poc 4 - #9122
Feature/plugins poc 4 #9122henryjonathanquispe wants to merge 17 commits into
Conversation
commit b84543b Author: AugustoLopezProcess <augusto.lopez+github@processmaker.com> Date: Tue Apr 21 08:27:15 2026 -0400 Adding plugin admin ui commit ca8a863 Author: Nolan Ehrstrom <github@nolanpro.com> Date: Mon Mar 9 11:01:46 2026 -0700 Add controllers and routes for plugin UI Copied from feature/plugins-poc-vite-ui (just without the vite/Vue3 integration) commit 3cc89bc Merge: 9e9b4aa 5da27ce Author: Nolan Ehrstrom <github@nolanpro.com> Date: Mon Mar 9 10:58:27 2026 -0700 Merge branch 'task/FOUR-28803' into feature/plugins-poc commit 9e9b4aa Author: Nolan Ehrstrom <github@nolanpro.com> Date: Mon Jan 19 12:30:54 2026 -0800 Add install command and cached routes commit 4a5df14 Author: Nolan Ehrstrom <github@nolanpro.com> Date: Wed Dec 10 09:29:20 2025 -0800 Start on plugins
Updating feature/plugins-poc-4 with last changes in develop
FOUR-32722 Some adjustments in plugins installation
…the command: php artisan horizon:terminate
FOUR-32760 After install/enable/disable a plugin, should be executed the command: php artisan horizon:terminate
…ink, add load screen-builder-form.js files from plugin
…ink, add load screen-builder-form.js files from plugin
…ink, add load screen-builder-form.js files from plugin
…ink, add load screen-builder-form.js files from plugin
PR SummaryHigh Risk Overview Admin surface: Multitenancy / runtime: Separately introduces the cross-project Reviewed by Cursor Bugbot for commit 1a97475. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 5 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
| } else { | ||
| $this->logRunning("Plugin {$command} command output:\n\n{$result->output()}", $pluginName, $userId); | ||
| } | ||
| } |
There was a problem hiding this comment.
Install command stderr treated as failure
High Severity
runCommand never throws and looks for is not defined only on stdout. Artisan writes that message to stderr, so a missing {plugin}:install or {plugin}:uninstall command is logged as error. PluginOutput then marks the job failed and ignores the later done event, even though composer install and copy already succeeded.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
| $this->runCommand($uninstallCommand, $pluginName, $userId); | ||
|
|
||
| $this->logRunning('Removing plugin directory...', $pluginName, $userId); | ||
| $this->removePluginPath($pluginPath, $pluginName, $userId); |
There was a problem hiding this comment.
Plugin name allows storage path traversal
High Severity
Uninstall, toggle, and reinstall interpolate the unsanitized {name} route parameter into storage/plugins/{name}. A name of .. resolves to the tenant storage directory, so uninstall recursively deletes it. Toggle would rename that same directory.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
|
|
||
| try { | ||
| $zip->extractTo($tmpExtractDir); | ||
| $zip->close(); |
There was a problem hiding this comment.
Zip extract allows path traversal
High Severity
installFromZip calls ZipArchive::extractTo on the uploaded archive with no entry-name sanitization. Entries such as ../ can write outside the temp directory before validatePlugin runs, including overwriting application files.
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
| } | ||
|
|
||
| return $composerJson; | ||
| } |
There was a problem hiding this comment.
Bad plugin JSON crashes tenant boot
Medium Severity
loadPlugins throws on invalid composer.json or a missing PSR-4 directory. That exception escapes the TenantResolved listener, so one corrupt plugin prevents the tenant from booting and serving requests.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
| public function broadcastOn() | ||
| { | ||
| return new PrivateChannel('ProcessMaker.Models.User.' . $this->userId); | ||
| } |
There was a problem hiding this comment.
Null user PluginLog still broadcasts
Medium Severity
PluginLog always implements ShouldBroadcastNow and builds ProcessMaker.Models.User.{userId} even when userId is null. CLI install/uninstall failure events fire without a user, so the worker broadcasts to ProcessMaker.Models.User. and can throw or hit an invalid private channel.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1a97475. Configure here.
|







Related Tickets & Packages
Code Review Checklist
ci:deploy