Skip to content

FOUR-32426 | Enable Task Preview on Saved-Search To Do and Self Service Lists - #9121

Open
mcraeteisha wants to merge 2 commits into
developfrom
bugfix/FOUR-32426
Open

mcraeteisha wants to merge 2 commits into
developfrom
bugfix/FOUR-32426

Conversation

@mcraeteisha

@mcraeteisha mcraeteisha commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Issue

Ticket: FOUR-32426

Self-service and in-progress (To Do) tasks on /tasks/saved-searches did not show the preview pane option. Users could not open the side preview from those saved searches the way they can from the main task list.

TasksList.vue excluded regular saved-search URLs from preview: it did not mount tasks-preview when the URL contained saved-searches, and it hid the Preview row action with the same check. That blocked preview for active and self-service tasks on those pages. Completed tasks remain out of preview scope (task_status === "CLOSED").

Also, on Completed and Self Service saved searches (no Due Date column), Status/date cell content was wrapped in a block-level div next to the row-action anchor. That stacked below the inline-block button box and added empty vertical space in the row. Due Date columns already use inline spans, so they did not show the same stacking.

Unaffected by design: Open Case / Open Task actions remain available; completed-task preview stays hidden.

Solution

processmaker

  • resources/js/tasks/components/TasksList.vue
    • Always mount tasks-preview (removed verifyURL('saved-searches') gate).
    • Preview action visibility uses shouldShowPreviewButton(row) (task_status !== "CLOSED"), including on saved searches.
    • Preserve API status on record.task_status before formatStatus replaces status with badge HTML.
    • Guard previewTasks() with the same eligibility helper.
    • Keep cell content wrappers as inline-block with vertical-align: middle so last-column Status/date content shares a line with the row-action anchor (same layout model as Due Date).
    • Compact formatStatus badge HTML to a single-line span.
  • resources/js/tasks/components/TaskListRowButtons.vue
    • Support show as a boolean or per-row function via shouldShow(button).
    • Add vertical-align: middle on .pm-task-row-buttons to align with adjacent cell content.

How To Test

Manual Tests

  1. Open /tasks/saved-searches → To Do with an in-progress task; hover the row and use Preview.
  2. Preview pane opens; Open Case / Open Task still work.
  3. Open Self Service with an unclaimed self-service task; hover and use Preview.
  4. Preview pane opens for the self-service task.
  5. Open Completed; confirm Preview is not shown for completed (CLOSED) tasks.
  6. Confirm Completed and Self Service row height no longer shows extra stacked space beside Status, and row hover actions still appear reliably.
  7. Confirm the main Tasks list (with Due Date) still shows Preview for active tasks and row actions behave as before.

ci:deploy

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

This commit updates task row button visibility to evaluate per-row conditions, so preview/open actions respect task status instead of a URL-only check. Preview is now hidden for closed tasks while remaining available for active/self-service tasks, including saved searches. It also aligns task cells and separators visually and preserves the task status needed for row-level actions.
@cursor

cursor Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
UI-only task list behavior and layout; no auth, API, or data-model changes beyond storing task_status on row objects for display logic.

Overview
Task preview on saved searches is no longer blocked by URL checks: tasks-preview always mounts, and the Preview row action uses per-row eligibility instead of hiding everything on /tasks/saved-searches.

Preview visibility is driven by shouldShowPreviewButton(row), which shows preview for non-CLOSED tasks (using task_status preserved before status is replaced with badge HTML). Quick Fill / Inbox Rules flows (fromButton: previewTask, fullTask, inboxRules) can still preview completed tasks. previewTasks() applies the same guard. Open Case and Open Task stay always visible.

Row layout fixes extra vertical space on Completed/Self Service lists (no Due Date column): status/HTML cell wrappers use inline-block + vertical-align: middle, and TaskListRowButtons supports show as a boolean or (row) => boolean via shouldShow(button), with matching alignment on the button container.

Reviewed by Cursor Bugbot for commit a7bc790. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a5d22c8. Configure here.

@nolanpro

nolanpro commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://tenant-1.ci-34f2800301.engk8s.processmaker.net

Removed the saved-search gate that hid the preview pane for active and self-service tasks, while keeping completed tasks excluded unless the task list explicitly allows preview actions.
@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants