You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(FOUR-34193): resolve V1.1 TaskController from the container on optimized index - #9115
GET /api/1.0/tasks with OPTIMIZED_TASKS_ENABLED=true (default) throws ArgumentCountError: new V1_1TaskController() skips DI for TaskCompletionRawService. Seen in Octane/FrankenPHP on Tasks inbox.
Solution
Resolve V1_1TaskController via app() so Laravel injects TaskCompletionRawService.
Add a regression test that GET /tasks with the flag on returns 200.
Low Risk
Single delegation-path fix with no change to non-optimized listing behavior; covered by a regression test.
Overview
When optimized tasks are enabled, TaskController::index no longer instantiates V1_1TaskController with new. It resolves the controller through app(V1_1TaskController::class) so Laravel injects TaskCompletionRawService, fixing the ArgumentCountError that broke GET /tasks (e.g. Tasks inbox under Octane/FrankenPHP).
A feature test asserts GET /tasks with processmaker_optimized_tasks_enabled on returns 200.
Reviewed by Cursor Bugbot for commit a4e5b13. Bugbot is set up for automated code reviews on this repo. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue & Reproduction Steps
GET /api/1.0/tasks with OPTIMIZED_TASKS_ENABLED=true (default) throws ArgumentCountError: new V1_1TaskController() skips DI for TaskCompletionRawService. Seen in Octane/FrankenPHP on Tasks inbox.
Solution
How to Test
php vendor/bin/phpunit tests/Feature/Api/TaskControllerTest.php --filter testIndexResolvesOptimizedV11ControllerFromContainerOpen Tasks inbox with the flag on (reload Octane after deploy). List should load, no 500.
Related Tickets & Packages
Code Review Checklist