Skip to content

FOUR-33960: Clear outdated Script Executor validation errors - #9112

Open
eiresendez wants to merge 2 commits into
developfrom
bugfix/FOUR-33960
Open

eiresendez wants to merge 2 commits into
developfrom
bugfix/FOUR-33960

Conversation

@eiresendez

@eiresendez eiresendez commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

A duplicate Script Executor name shows a validation error that stays visible after changing the name or language. Open Admin > Script Executors, enter an existing name for the same language, and select Save and Build. Then change the name or language.

Solution

  • Clear the name error when the name or language changes.
  • Clear the language error when the language changes.
  • Clear previous errors before each save attempt. Keep server-side uniqueness validation unchanged.

How to Test

Browser smoke passed: duplicate names are rejected, changing the name clears the error, retrying a duplicate shows the error again, and changing the language clears the error.

Component checks passed for create and update retries with simulated API responses. Successful executor builds were not exercised.

Related Tickets & Packages

ci:deploy
Redeploy 4, Nov 2026

@cursor

cursor Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Client-side validation display only; server-side uniqueness checks are unchanged.

Overview
Fixes stale Script Executor validation errors in the admin modal: name/language uniqueness failures no longer stick after the user edits those fields.

formData.title and formData.language watchers remove the relevant entries from errors as the user types or picks a new language (language changes clear both title and language errors). save() now resets errors to {} before each save/build so a new attempt does not show messages from the previous request.

Reviewed by Cursor Bugbot for commit 6c9767e. Bugbot is set up for automated code reviews on this repo. Configure here.

@eiresendez eiresendez self-assigned this Oct 22, 2026
@sanjacornelius
sanjacornelius self-requested a review October 26, 2026 17:51
@nolanpro

nolanpro commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://tenant-1.ci-44c834adac.engk8s.processmaker.net

@eiresendez

Copy link
Copy Markdown
Contributor Author

The failing check is caused by a connection timeout to SonarQube while querying /api/v2/analysis/version. PHPUnit completed successfully with exit code 0; the failure occurred during the subsequent scan. This points to a CI connectivity issue.

@nolanpro

Copy link
Copy Markdown
Contributor

QA server K8S was successfully deployed https://tenant-1.ci-44c834adac.engk8s.processmaker.net

@decisions-sonarqube

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants