Skip to content

FOUR-33730: [PERF] Phase 4: Platform Performance Tentpole Project - #9103

Draft
pmPaulis wants to merge 16 commits into
developfrom
epic/FOUR-33730
Draft

pmPaulis wants to merge 16 commits into
developfrom
epic/FOUR-33730

Conversation

@pmPaulis

@pmPaulis pmPaulis commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Phase 4: Platform Performance Tentpole Project

Related Tickets & Packages

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

ci:deploy

gproly and others added 16 commits July 9, 2026 00:04
…plified layout

Description:
All pages are loading a large amount of JavaScript that is not always used.

- Context
There is about 2000ms of JavaScript execution.
This includes non-used libraries like monaco.

- Acceptance criteria
Have a simplified layout that loads the minimum assets.
Allow some pages to be refactored to use this simplified layout.

Related tickets:
https://processmaker.atlassian.net/browse/FOUR-32127
Introduce LayoutAssetManager with route-based profiles so layout.blade.php
loads lightweight bundles on inbox/tasks. Lazy-load Process and DashboardViewer
in tasks/router.js to defer heavy JS until navigation.
…e.g. lightweight inbox vs full default).

Keeps asset loading declarative and extensible;
feat(FOUR-32025): Review performance: DB access and queries in login can be cached into redis, images
FOUR-32127 LAYOUT Javascript base is very large >> Idea: Create a sim…
@cursor

cursor Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

PR Summary

Medium Risk
Inbox/tasks now depend on a reduced JS profile that omits modeler/Monaco; regressions there are possible if those pages still need those globals. Branding URL and cache-busting behavior changed for custom and default assets.

Overview
Introduces route-based layout asset profiles so inbox/tasks pages load a slimmer JavaScript stack (app-core.js / app-layout-core.js) and skip modeler vendor and Monaco, while other routes keep the full app.js / app-layout.js bundles. Shared bootstrap logic moves into bootstrap-base.js / bootstrap-core.js, with full bootstrap.js retaining only modeler/Monaco additions; Mix builds the new entrypoints and minifies app.css.

Inbox routing now lazy-loads process and dashboard views, uses a lightweight placeholder on the default inbox route, and parses dashboard session data more safely.

Branding helpers in Setting treat “default login” as absence of custom login media, use updated_at cache-busting for uploaded logos/icons/favicons, and stop appending random query strings on default asset URLs. Login views get minor perf/accessibility tweaks (deferred scripts, logo fetchpriority/dimensions, password-toggle styles).

Remaining diff is mostly formatting (console command, migrations, microservice cache) and test import cleanup.

Reviewed by Cursor Bugbot for commit a11a879. Bugbot is set up for automated code reviews on this repo. Configure here.

@decisions-sonarqube

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a11a879. Configure here.

<script src="{{ mix('builds/login/js/app-login.js') }}"></script>
<script src="{{ mix('builds/login/js/manifest.js') }}" defer></script>
<script src="{{ mix('builds/login/js/vendor.js') }}" defer></script>
<script src="{{ mix('builds/login/js/app-login.js') }}" defer></script>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Login defer wipes package list

High Severity

Mix login bundles manifest.js, vendor.js, and app-login.js now load with defer, and ProcessMaker.packages is assigned only inside a DOMContentLoaded listener. app-login.js replaces window.ProcessMaker with packages: [] during the deferred phase, so deferred GlobalScripts and app-bootstrapped handlers still observe an empty package list.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: Login bundles must not wipe ProcessMaker.packages

Reviewed by Cursor Bugbot for commit a11a879. Configure here.

Vue.component("Breadcrumbs", Breadcrumbs);
Vue.component("TimelineItem", TimelineItem);
Vue.component("Required", Required);
Vue.component("Welcome", WelcomeModal);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core layout omits file components

Medium Severity

app-layout-core.js is the inbox profile stand-in for app-layout.js but never registers global FileUpload, FileDownload, or RequiredCheckbox. Any Mix layouts.layout page that resolves the inbox profile therefore mounts without those screen-builder components, so file controls on request/start screens and dashboards fail to render.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a11a879. Configure here.

@vladyrichter

Copy link
Copy Markdown

QA server K8S was successfully deployed https://tenant-1.ci-f95c9add9d.engk8s.processmaker.net

@pmPaulis
pmPaulis marked this pull request as draft November 12, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants