Skip to content

FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed - #9099

Open
devmiguelangel wants to merge 5 commits into
developfrom
FOUR-6787
Open

devmiguelangel wants to merge 5 commits into
developfrom
FOUR-6787

Conversation

@devmiguelangel

@devmiguelangel devmiguelangel commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed

An Intermediate Throw Event with two or more incoming sequence flows behaved like an AND-join. TransitionTrait::hasAllRequiredTokens only fired the shared transition when every incoming state had a token, and one firing consumed one token from each incoming flow. When an exclusive or parallel split delivered a token on only some of those flows, the event never fired and the request stayed In Progress.

The event is no longer a join. IntermediateThrowEventTransition fires as soon as any incoming flow has a token and consumes exactly one token per firing, so each arriving token triggers the event and continues downstream. The graph is unchanged: one incoming state per sequence flow, all connected to the same transition. Token persistence and ThrowEventTokenPassed still happen on that transition, which keeps the previous event order for boundary and message tests.

Before this change the transition waited until inA, inB, and inC all held a token. Now a token on any one of them is enough.

Related Tickets

FOUR-6787
ProcessMaker/nayra#240

ci:nayra:FOUR-6787

ci:deploy

@cursor

cursor Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Adds tests and a fixture only; no application or workflow engine code changes in this diff.

Overview
Adds integration coverage for FOUR-6787 so an Intermediate Message Throw Event with several incoming sequence flows does not behave like an AND-join after the Nayra workflow fix.

A new process fixture (four_6787_intermediate_throw_event.json) models an exclusive gateway with three branches that all converge on node_19, then end at a message end event. IntermediateThrowEventMergeTest imports that process, starts a request, picks each branch via select (1, 2, or 3), completes the branch form task, and asserts the request reaches COMPLETED.

Reviewed by Cursor Bugbot for commit d30cef1. Bugbot is set up for automated code reviews on this repo. Configure here.

@devmiguelangel devmiguelangel changed the title test: add tests for Intermediate Message Throw Event behavior FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed- #240 Oct 13, 2026
@devmiguelangel devmiguelangel self-assigned this Oct 13, 2026
cursor[bot]

This comment was marked as outdated.

@devmiguelangel devmiguelangel changed the title FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed- #240 FOUR-6787 If more than two tasks end in an Intermediate Signal Throw Event Element, the flow will not be correctly completed Oct 14, 2026
@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants