Repository navigation
FOUR-33773 | Add Out of Office Status and Delegation for Users With Edit Personal Profile Permission #9098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcraeteisha
wants to merge
12
commits into
develop
Choose a base branch
from
task/FOUR-33773
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
FOUR-33773 | Add Out of Office Status and Delegation for Users With Edit Personal Profile Permission #9098
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
87d77e7
Allow self-service profile delegation
mcraeteisha 8de3728
Resolve CursorBot Issue
mcraeteisha 072862f
Fix delegated assignee handling for OOO users
mcraeteisha 7a0f613
Resolve unavailable assignee to process manager
mcraeteisha dc43686
Merge branch 'develop' into task/FOUR-33773
mcraeteisha 247dc26
Enforce ACTIVE delegation and assignee resolution
mcraeteisha 41aef59
Merge branch 'develop' into task/FOUR-33773
mcraeteisha 254caa3
Merge branch 'develop' into task/FOUR-33773
mcraeteisha a4ec320
Merge branch 'develop' into task/FOUR-33773
mcraeteisha 7c4a194
Merge branch 'develop' into task/FOUR-33773
mcraeteisha 3dbaf73
Merge branch 'develop' into task/FOUR-33773
nolanpro 0e25936
Lower UserController update cognitive complexity for SonarQube.
nolanpro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Agentic Security Review
Severity: MEDIUM
Description: A user with only edit-personal-profile can PUT /api/1.0/users/{self} and store status OUT_OF_OFFICE plus delegation_user_id set to any other active, non-system user. Process-variable assignment then puts that delegate into the assignee pool with no check that they are on the task's user or group list. The resulting process_request_tokens.user_id is enough for ProcessRequestTokenPolicy to allow view and complete, and for ForUserScope to show the parent request.
Impact: The previous self-service denylist kept delegation_user_id with manager_id, so only an edit-users administrator could name a backup. This change lets an ordinary profile user redirect future process-variable work — including request data and task completion — to an account the process never assigned. That is a cross-user task and request-data boundary, not a personal display preference. Fixed user, group, and user_by_id assignment do not perform this substitution, and delegateTask only writes an assignee when an external assignment process exists.
Remediation: Do not accept an unconstrained delegation_user_id on the personal-profile allowlist. Keep the column admin-managed, or before saving it require a relationship that is allowed to receive this user's work (same task assignment list, shared group, or an explicit delegate grant). Apply that same check in getNextUserFromProcessVariable and getNextUserFromProcessVariableRaw before copying the id into process_request_tokens.user_id.