Repository navigation
feat(FOUR-32025): Review performance: DB access and queries in login can be cached into redis, images #8931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fbb9f96
feat(FOUR-32025): Review performance: DB access and queries in login …
rodriquelca e24e6c7
fix: restore reset_blade
rodriquelca b2be9e0
fix: restore app-login
rodriquelca 45c82d7
fix: remove hardcoded value
rodriquelca f8417ba
fix: resolve code review notes
rodriquelca 355efdb
solving conflicts
pmPaulis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
resources/views/auth/partials/auth-language-scripts.blade.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| <script src="{{ mix('builds/login/js/manifest.js') }}"></script> | ||
| <script src="{{ mix('builds/login/js/vendor.js') }}"></script> | ||
| <script src="{{ mix('builds/login/js/app-login.js') }}"></script> | ||
| <script src="{{ mix('builds/login/js/manifest.js') }}" defer></script> | ||
| <script src="{{ mix('builds/login/js/vendor.js') }}" defer></script> | ||
| <script src="{{ mix('builds/login/js/app-login.js') }}" defer></script> | ||
| @include('auth.partials.auth-language-scripts-minimal') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stale logo after re-upload
High Severity
Returning inside the
getMedialoop selects the first collection item. Customize UI appends a new media row on every upload and Spatie orders byorder_columnascending, so a replacement keeps the original file URL andupdated_atcache key. Browsers then keep serving the old cached login logo, favicon, icon, or sidebar logo.Additional Locations (3)
ProcessMaker/Models/Setting.php#L354-L357ProcessMaker/Models/Setting.php#L380-L383ProcessMaker/Models/Setting.php#L406-L409Reviewed by Cursor Bugbot for commit 355efdb. Configure here.