Repository navigation
Syntax-check every top-level module in the workflow - #64
Merged
Merged
Conversation
The Check syntax step listed modules by name and had fallen behind text_renderer.py, console_view.py and viron_address.py. A shell glob covers them and any module added later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the PR head, after the
Judgment call: Merge hold: This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Check syntaxstep in.github/workflows/tests.ymlnow runspython -m py_compile *.pyinstead of naming seven modules. The list had fallen behindtext_renderer.py,console_view.pyandviron_address.py; the glob covers all ten top-level modules and any module added later, so the step no longer needs editing per module.Running the testssection no longer names those three modules as exceptions.The runner's default shell is bash, and the glob matches only files in the repository root, so
tests/and the unpopulatedViron/directory are not compiled (as before).Closes #61
Test plan
python3 -m py_compile *.pypasses locally across all ten top-level modulespython3 -m unittest discover -s tests— 205 tests ran, OKTestsworkflow green on this PRMerge note
This PR modifies
.github/workflows/, which is on the dev loop's do-not-auto-merge list, so it is left open for a human to merge.Deferred issues
Vironsubmodule, which needs explicit authorization.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson