Repository navigation
Say which tests mock Pygame and which modules they import - #53
Merged
Merged
Conversation
The README said most tests mock Pygame, but the usage-reporting and trace-client tests, which make up nearly half the suite, do not involve Pygame at all. It also named only main.py and render_window.py as the modules the tests need to import from the repository root. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against the diff and command output):
README.md:195 — judgment note: the word "also" in " Do-not-auto-merge paths: none touched (no This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage A documentation accuracy sweep. Every section of
README.mdand the three batch scripts was re-checked againstmain.py,render_window.py,graphik.py,headless_run.py,usage_reporting.py,trace_client.py,.github/workflows/tests.ymland the pinnedVironsubmodule. Two inaccuracies were found, both in Running the tests:tests/test_usage_reporting.pyandtests/test_trace_client.pynever touch Pygame, and the 10 intests/test_batch_scripts.pyonly read the.batfiles. Only themain.py,render_window.pyandgraphik.pytests (64) mock it. The sentence now says which tests mock Pygame, which one runs the real Pygame, and which have nothing to do with it.main.pyandrender_window.pyare importable" left out four of the six top-level modules that the tests import:graphik.py,headless_run.py,usage_reporting.pyandtrace_client.py. All six are now listed.Everything else checked out against the source, including the CLI argument handling, the
environments.jsonformat, the load/create failure behaviour, the batch scripts, the headless harness, the CI workflow, the Python 3.9 requirement (thelist[Environment]annotation in Viron'senvironmentService.py) and the usage-reporting opt-outs. No code was changed.No tracking issue — gap found during triage.
Test plan
python3 -m unittest discover -s tests:Ran 150 tests,OK(Python 3.8.10, Viron stubbed)grep -c "def test" tests/*.pyandgrep -l pygame tests/*.pyREADME.mdDeferred issues
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson