Repository navigation
Document Graphik and correct the README's usage-reporting details - #51
Merged
Merged
Conversation
The README said usage reporting is started only by the CLI entrypoint, but main() starts it whenever reportUsage=True is passed. It also left out the DO_NOT_TRACK values true/yes, the case-insensitive matching of both opt-out variables, and what happens when settings.json cannot be read. Graphik, which main.py renders with, had no description at all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on the
Findings flagged for judgment (none block the merge):
Every rubric item passes and the anchor is green for a docs-only change. This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A documentation accuracy sweep (Stage A) of
README.mdand the batch scripts was carried out against the current source. Each corrected claim below was checked against the code:main()'sreportUsageargument. The README said usage reporting is "started only by the CLI entrypoint". In factmain()takesreportUsage(defaultFalse), and the__main__block passesTrue. The parameter is now documented, and the sentence states the condition under whichsettings.jsonis left alone.trace_client.environment_opts_outalso acceptsDO_NOT_TRACK=true/yes, ignores case and surrounding whitespace, and treats any other value as no opt-out. The README listed onlyDO_NOT_TRACK=1and did not mention case.settings.json.usage_reporting.loadSettingsprints a message, does not rewrite the file, and returnsNone, so nothing is reported for that run. The README did not describe this case.main.pyrenders withGraphik, but the README mentioned it by name only. A short section now documentsdrawRectangle,drawText(bundledfreesansbold.ttffont, centred) anddrawButton(fires once per press, keyed by its rectangle, and not when a press is dragged onto it). These behaviours are the ones locked in bytests/test_graphik.py.The rest of the README (CLI arguments, cache behaviour, load/create error paths,
create_environments.bat/up.bat/down.bat, the test and headless-harness sections, the CI workflow description) was re-verified and no drift was found.Only documentation is changed. No code is modified.
Skipped issues
Vironsubmodule is also never re-pointed without authorization.Test plan
python3 -m py_compile main.py graphik.py __init__.pypassespython3 -m unittest discover -s testsran 141 tests, all OKdrawRectangle(..., "red")produced a(255, 0, 0)pixel, anddrawText/drawButtonwith colour names ran without error.python3 main.py 10 --exit-after-createagainst a Viron on:9999): UNVERIFIED-not-applicable. This PR is docs-only, and no Viron can run in this environment.No tracking issue: the gaps were found during triage.
This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson