Repository navigation
Document and characterize what happens when environment creation fails - #43
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchored on CI run 38877431961,
Judgment call, not blocking: "the program exits with a traceback" describes the CLI. A direct This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage B characterization test plus the matching README note, covering a path that had neither: what happens when
environmentService.create_environmentfails.tests/test_main.py:test_a_failed_creation_propagates_without_recording_the_environmentasserts the current behaviour. The exception propagates out ofmain(), a pre-existingenvironments.jsonentry is left untouched and no new one is added, noenvironment-createdevent is reported, and the render loop is never entered.README.md(Running): a paragraph after the failed-load note states that creation is not guarded in the same way. The program exits with a traceback and a non-zero status, the cache and usage report are unaffected, andcreate_environments.batdepends on that status to print itsError occurred…line, with the traceback going toerror_log.txt.No production code is changed. The test deliberately makes no assertion about
window.close(), which is not called on this path, unlike the failed-load path. That asymmetry looks unintended, so it was filed as #42 for an owner decision and was not locked in by the test.No tracking issue covers this. The gap was found during triage.
Skipped issues
Vironsubmodule (and add bearer-token support) or keep the pin is a project decision, and re-pointing the submodule needs explicit authorization.Test plan
python3 -m py_compile main.py graphik.py __init__.py: passespython3 -m unittest discover -s tests: ran 124 tests, OK (123 before, plus 1 new)main.py(notryaroundcreate_environment; the cache write andusage.reportcome after it), to Viron'senvironmentService.py(raise_for_status()), and tocreate_environments.bat(if errorlevel 1)This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson