Repository navigation
Pin where directional moves start and when they throw - #81
Merged
dmccoystephenson merged 1 commit intoNov 11, 2026
Merged
Conversation
Directional moves look up the entity's current location by its location id, outside the try that turns an off-grid step into false. Two tests pin that the move steps from the named location and that an id naming no grid location throws and leaves the entity in place; the README documents both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (anchor: CI run 42985819569,
Observations:
This comment was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
dmccoystephenson
deleted the
feature/pin-directional-move-start-location
branch
November 11, 2026 08:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Environment::moveEntityInDirectionfinds the starting location withGrid::getLocation(entity.getLocationId()), which runs before thetrythat turns an off-grid step intofalse. Neither behavior was tested or documented.0-1-1with its location id set to0-0-0, andmoveEntityRightputs it in0-1-0.moveEntityUpandmoveEntityToRandomAdjacentLocationthrowstd::runtime_errorwhen the location id names no grid location, and that the entity stays where it was.No tracking issue: the gap was found during triage. The issue tracker was empty at triage, so no issues were skipped.
Test plan
Library tests (make + CMake)runsbash run_tests.shand every test through Test 81 prints--- Success. Local runs of the test binary are denied in this environment, so CI is the anchor.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson