Repository navigation
Run the AddressSanitizer test build in CI - #80
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric (scored against CI run 42460881589 and the diff):
This review was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener). drafted by Claude on behalf of Daniel Stephenson |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddressSanitizer build and runstep (bash run_tests_asan.sh) is added to thelibraryjob in.github/workflows/ci.yml, directly afterbash run_tests.sh. A use-after-free,new/deletemismatch, or leak that does not trip anassert()now fails CI on pull requests and on pushes tomaster.README.md's "Running Tests" section now states that CI runs both scripts.run_tests_asan.shhas noset -e, but its last command is the sanitizer binary itself, so the script's exit status is the binary's, and a sanitizer report fails the step.Closes #75
Test plan
Library tests (make + CMake)job on this PR runs the new step and it passes, which shows that the current suite is clean under ASan with leak detection onbash run_tests.shand the CMake/ctest steps still passMerge hold
This PR edits
.github/workflows/ci.yml, which is on the dev loop's do-not-auto-merge list, so it is left open for human review rather than merged automatically.This PR description was drafted during a Gardener session (https://github.com/Stephenson-Software/gardener).
🤖 Generated with Claude Code
drafted by Claude on behalf of Daniel Stephenson