Repository navigation
ci(workflows): call the shared test workflow [FACT-1885] - #2
Conversation
Publish still uses npm trusted publishing and only borrows the shared install. Co-authored-by: Cursor <cursoragent@cursor.com>
practical-bot
left a comment
There was a problem hiding this comment.
Review
The two changed workflow files are a focused migration and the consumer check is wired correctly. The current CI run is the expected proof of the delegation: run 43368079880 has the job steps Run PracticalWorks/.github/.github/actions/setup@v1, lint (skipped because the input is empty), test (skipped because the input is empty), and run; the run log executes pnpm guard, pnpm build, pnpm typecheck, and pnpm test successfully. The reusable workflow is pinned to @v1, and publish uses the shared setup action at @v1 without adding a repository secret.
Finding
- The PR does not meet FACT-1885's consumer and Done-when scope. The current body says, "CI calls
PracticalWorks/.github/.github/workflows/test.yml@v1for guard, build, typecheck, and test," which is true for this CRM PR, but this diff contains only.github/workflows/ci.ymland.github/workflows/publish.yml. It does not migrate the factory deploy workflows or eitherstr-job-hunter/str-manager, so it cannot establish the ticket's required "The CRM repo and the factory deploy through the shared workflows" or the one-line change reaching both. The tracker also linksPracticalWorks/.github/pull/1, whose latest review records that those migrations are still outstanding. This is an acceptance-criteria gap, not a preference.
The body also says, "The shared guard tests passed in the workflow repository." I did not rerun that separate repository's tests from this checkout, so that claim is UNVERIFIED here; the CRM consumer run above is independently verified.
Verdict
REVIEW VERDICT: changes-requested
FINDING: FACT-1885 still lacks the required factory and private-app consumer migrations; this PR changes only CRM workflow files, so the ticket's consumer/Done-when scope is unmet -> DROPPED (the existing FACT-1885 card owns this scope; no new card filed)
NEEDS VERIFICATION: After the migrations merge, walk the ticket's live GitHub check showing both PracticalWorks/crm and practical-works-factory jobs sourced from PracticalWorks/.github/.github/workflows/...@<tag>, and confirm per-repository Actions billing remains readable.
|
The head-specific native review is already recorded as CHANGES_REQUESTED. For the current head, the blocking finding remains: this CRM-only PR does not migrate REVIEW VERDICT: changes-requested |
|
On the finding that "the factory and private-app consumer migrations are absent": agreed, they aren't in this diff, and they shouldn't be. A CRM PR cannot change another repository's workflows, so each consumer has its own PR off its own default branch:
The body now opens with that deploy order and carries the net line (-9, +13/-22). What is still open for FACT-1885 is outside this repository: the factory and frontdesk Coolify deploys need an Infisical GitHub-OIDC identity before they can use Evidence on this head ( |
practical-bot
left a comment
There was a problem hiding this comment.
@Echobob re-reviewed eea3395: verdict unchanged (changes-requested).
The workflow migration itself is correct: ci.yml delegates guard/build/typecheck/test to PracticalWorks/.github/.github/workflows/test.yml@v1, publish.yml uses the shared setup action at @v1, and CRM run 43368079880 passed on this head with the shared setup step and the declared run commands. No repository secret was added. git diff --check is clean.
FINDING: FACT-1885's current card still requires the factory's deploy workflows and a private app consumer to move, plus the Done-when requires CRM and the factory to deploy through shared workflows; this CRM-only diff cannot establish those requirements -> DROPPED (owned by FACT-1885; the coordinated caller PRs and the card scope remain outstanding)
UNVERIFIED: The PR-body claim that the shared guard tests passed in PracticalWorks/.github was not rerun from this checkout; the CRM consumer run above is verified by CI.
UNVERIFIED: actionlint could not be run because it is unavailable in this workspace (command -v actionlint exited 127); no CI row for actionlint was present.
NEEDS VERIFICATION: After the coordinated migrations merge, verify CRM and practical-works-factory jobs source PracticalWorks/.github/.github/workflows/...@<tag> and confirm per-repository Actions billing remains readable.
REVIEW VERDICT: changes-requested
|
@Echobob re-reviewed eea3395: verdict unchanged (changes-requested). The workflow migration itself is correct: FINDING: FACT-1885's current card still requires the factory's deploy workflows and a private app consumer to move, plus the Done-when requires CRM and the factory to deploy through shared workflows; this CRM-only diff cannot establish those requirements -> DROPPED (owned by FACT-1885; the coordinated caller PRs and card scope remain outstanding) REVIEW VERDICT: changes-requested |
|
@jcotillo re-reviewed eea3395: verdict unchanged (changes-requested). The workflow migration itself remains correct: FINDING: FACT-1885's current card still requires the factory deploy workflows and a private app consumer to move, while the Done-when requires CRM and the factory to deploy through shared workflows; this CRM-only diff cannot establish those requirements -> DROPPED (owned by FACT-1885) REVIEW VERDICT: changes-requested |
|
Review unverified for eea3395. The ticket's acceptance criteria could not be read. No model review ran and no approval was issued. Reason: Plane resolveWorkItemRef did not answer within 15000ms (after 2 attempts) |
practical-bot
left a comment
There was a problem hiding this comment.
Review
Re-reviewing the full pull request against the current FACT-1885 scope. The card now explicitly treats the factory and frontdesk migrations as separate consumer changes, and this PR's body states that those changes are not duplicated in the CRM repository. That resolves the earlier scope concern for this CRM PR; the remaining cross-repository and billing checks are post-merge verification, not a defect in this diff.
The workflow implementation is correct: .github/workflows/ci.yml delegates the CRM checks to PracticalWorks/.github/.github/workflows/test.yml@v1, retains both pull-request and main-push triggers, and passes the repository's guard/build/typecheck/test commands through the shared workflow. .github/workflows/publish.yml replaces the local pnpm/Node setup with PracticalWorks/.github/.github/actions/setup@v1, while preserving the publish permissions, OIDC behavior, and package publishing steps. Refs: FACT-1885 is present, and no UI files are changed.
Claim ledger
- “CI calls
PracticalWorks/.github/.github/workflows/test.yml@v1for guard, build, typecheck, and test.” PASS / VERIFIED-BY-CI: exact-head run43872615840ranPracticalWorks/.github/.github/actions/setup@v1; itsrunstep executedpnpm guard,pnpm build,pnpm typecheck, andpnpm testsuccessfully. - “Publish uses npm trusted publishing and borrows only the shared setup action for installation.” PASS: the diff changes only the setup action and its version inputs; npm OIDC permissions, the npm publish command, and the scoped
NODE_AUTH_TOKENGitHub Packages step remain intact. - “Local verification passed:
pnpm guard,pnpm build,pnpm typecheck,pnpm test(127 tests), andgit diff --check.” PASS / VERIFIED-BY-CI: exact-head run43872615840passed the declared guard, build, typecheck, and test commands;git diff --check origin/main...HEADpassed locally.pnpm guardalso passed locally with 7 tests andguard: 67 files clean.
REVIEWED DIFF: base=main files=2 lines=35
REVIEW VERDICT: approve
REVIEWED DIFF: base=main files=2 lines=35
NEEDS VERIFICATION: After the coordinated consumer migrations merge, verify that CRM and practical-works-factory GitHub Actions jobs source PracticalWorks/.github/.github/workflows/...@v1, frontdesk's image build does too, and organization Actions usage remains readable per repository.
|
Re-review follow-up for FACT-1885 / PR #2: the native Talos approval for head |
Deploy order
PracticalWorks/.github#1(the shared workflows) first. Thev1tag is already available.practical-works-acropolis/practical-works-factory#1159andPracticalWorks/frontdesk#475.Why
This repository copied pnpm and Node setup into its own workflows until the shared workflows existed. A setup fix would otherwise have to be repeated here.
What changed
Net source lines vs
main: -9 (+13/-22). The local pnpm and Node setup steps are replaced by the shared ones.CI calls
PracticalWorks/.github/.github/workflows/test.yml@v1for guard, build, typecheck, and test. Publish uses npm trusted publishing and borrows only the shared setup action for installation.What deliberately did NOT change
The publish decision, the trusted-publisher OIDC permissions, and the package contents. No repository secret was added.
NODE_AUTH_TOKENremains unset for the npm trusted-publishing step.The factory and frontdesk migrations are deliberately not duplicated in this repository: they are separate consumer changes in their respective repositories and cannot be included in a CRM pull request.
Verification
pnpm guard,pnpm build,pnpm typecheck,pnpm test(127 tests), andgit diff --check.Refs: FACT-1885
Made with Cursor