Repository navigation
ci(workflows): v1.3.0 — coolify-deploy can skip the wait and run a pre-deploy step [FACT-2001] - #5
Conversation
…e-deploy step [FACT-2001] coolify-deploy.yml takes `wait` (default true, so existing callers are unchanged) and `pre-deploy-run`. With wait false the job posts the webhook, outputs the deployment uuid and exits: the caller is billed for seconds instead of the ~3 minutes Coolify takes, and something off the runner watches the deployment (for frontdesk, the factory door). health-url is refused with wait false, since it would never be polled. pre-deploy-run runs a shell command in a checkout of the caller's commit after Infisical and Node are set up, before the webhook, so an env sync folds into the deploy job instead of a separate job with its own one-minute minimum. The script fallback refs move to v1.3.0. Refs: FACT-2001 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
practical-bot
left a comment
There was a problem hiding this comment.
Review
The current FACT-2001 card is newer than the earlier PR comments: I judged this head against the current acceptance criteria and the split delivery recorded on the card. This PR correctly implements the .github v1.3.0 slice: wait defaults to true, wait: false posts once and returns the deployment UUID without polling, health-url is rejected when no wait occurs, and pre-deploy-run runs in the caller checkout after secrets/Node setup and before the webhook. The fallback ref and README release row are updated consistently. The tests also cover the new no-wait behavior and workflow ordering.
Claim ledger
- “
node --test scripts/*.test.mjs: 30 pass, 0 fail.” — PASS. Command:node --test scripts/*.test.mjs. Output:1..30,# tests 30,# pass 30,# fail 0. - “New tests cover
wait: false(one POST, uuid output, no polls), refusinghealth-urlwithwait: false, and that the caller checkout comes before the shared one and the pre-deploy step runs after secrets/node and before the webhook.” — PASS. The changed tests are 30 and 31 inscripts/coolify-deploy.test.mjsandscripts/workflows.test.mjs; the same 30-test command passed. - “
actionlint: the only findings arejob.workflow_sha/job.workflow_repository, which actionlint does not know yet. They are unchanged frommain.” — UNVERIFIED in this review workspace: commandactionlintreturnedsh: 1: actionlint: not found(exit 127). The PR CIguard / checkandguard-testsboth passed on head037c72a; the local absence is an environment limitation, not a PR finding.
The PR checks were read in full: guard / check and guard-tests passed on head 037c72a. The local test command independently passed. git diff --check also passed.
REVIEWED DIFF: base=main files=6 lines=102
NEEDS VERIFICATION: After the dependent frontdesk and factory changes merge, the newest frontdesk Build & Push Docker Image run on main has exactly two jobs, the deploy job finishes in under a minute, and frontdesk /health answers 200.
REVIEW VERDICT: approve
|
Review evidence for FACT-2001 on head
|
Why
PracticalWorks is past its 2,000 free Actions minutes. Each frontdesk deploy bills ~10 minutes across three hosted jobs: build 5, a separate env sync 1, and the Coolify deploy 4, most of it idle polling. These two inputs let a caller cut the deploy to one job of under a minute.
What changed
coolify-deploy.ymltakeswait(boolean, defaulttrue, so every existing caller is unchanged). Withfalse,scripts/coolify-deploy.mjsposts the webhook, writes thedeployment-uuidoutput and exits. It refuseshealth-urlin that mode, because the URL would never be polled.pre-deploy-run(default empty): a shell command run in a checkout of the caller's commit, after Infisical exports andsetup-node, before the webhook. That folds frontdesk's env sync into the deploy job. The caller checkout happens before the.pw-sharedcheckout, so it can't clean that one away.v1.3.0(the README-newest test pins this), and the README gets a v1.3.0 row plus documentation for both inputs.After merge this needs the tag
v1.3.0on the merge commit. frontdesk's PR pins it.Verification
node --test scripts/*.test.mjs: 30 pass, 0 fail. New tests coverwait: false(one POST, uuid output, no polls), refusinghealth-urlwithwait: false, and that the caller checkout comes before the shared one and the pre-deploy step runs after secrets/node and before the webhook.actionlint: the only findings arejob.workflow_sha/job.workflow_repository, which actionlint does not know yet. They are unchanged frommain.Refs: FACT-2001
🤖 Generated with Claude Code