Repository navigation
docs(profile): what we are now, every open-source project, no dead links - #3
Conversation
…rop the dead blog link Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
practical-bot
left a comment
There was a problem hiding this comment.
The profile wording and link cleanup are directionally correct: the new positioning names Tampa Bay and says what the shop does, the five listed project links and practical.works links resolved in the literal curl check (all returned 200; practical.works/call redirected to /book), and the current CI run 44013329807 passed both guard / check and guard-tests. The PR body also correctly includes Refs: PWMKT-643.
The PR does not meet the current card's acceptance criteria. The body explicitly says TurnWrk/shared is left out, but the card requires the profile to list TurnWrk/shared among every public project. This is a scope gap in the changed implementation, not a preference: gh repo view TurnWrk/shared --json isPrivate reported false and its public URL is https://github.com/TurnWrk/shared.
The card also requires every public repository README to end with the maintainer note, every public npm package to have author, public homepage, and bugs, and repo descriptions/topics. This PR changes only profile/README.md, so those repository/package-wide criteria are not implemented or evidenced by this diff. In particular, the live npm registry check showed @practicalworks/guardrails@0.4.0 has homepage and bugs but no author field, while the other checked packages (@practicalworks/rc-bridge@0.1.2, @practicalworks/rc-client@0.1.2, and @practicalworks/crm@0.13.2) did expose author, homepage, and bugs. The profile-only change cannot satisfy the guardrails author requirement.
Claim ledger:
- “practical.works/call → 200; the practical-works-acropolis inngest-vps and claude-code-secret-guard repos → 200”: PASS.
curl -L -sS -o /dev/null -w '%{http_code} %{url_effective}'returned200 https://practical.works/book,200 https://github.com/practical-works-acropolis/inngest-vps, and200 https://github.com/practical-works-acropolis/claude-code-secret-guard. - “blog.practical.works and practical.works/blog are dead, so they were removed”: PASS for the changed file: neither URL occurs in
profile/README.md, and the diff removes the blog section. - “The guardrails description matches its README”: UNVERIFIED as a complete external-repository claim in this checkout; the changed profile text is consistent with the stated description, but this repository contains no guardrails README to compare.
- CI: VERIFIED-BY-CI for the two jobs on exact head
17ba766ffc98006c40a6fdcf7d641821346c4f70;guard-testsran its script unit tests andguard / checkran PR body and guardrails.
REVIEW VERDICT: changes-requested
REVIEWED DIFF: base=main files=1 lines=32
FINDING: The profile explicitly omits public TurnWrk/shared, violating the card's required complete project list; gh repo view TurnWrk/shared --json isPrivate returned false -> DROPPED (no; must be fixed in the PR)
FINDING: The one-file profile diff cannot satisfy the card's required maintainer notes across every public README or package metadata across every public npm package; live registry data shows @practicalworks/guardrails@0.4.0 has no author field -> DROPPED (no; must be fixed in the PR or the card must be re-scoped)
|
Supplemental review evidence for PWMKT-643: the native review above requested changes. The checked-out head is |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
practical-bot
left a comment
There was a problem hiding this comment.
@jcotillo re-reviewed 514d8b2: verdict changed from the prior head's changes-requested to approve.
The delta adds the previously omitted public TurnWrk/shared project to the profile and corrects the guardrails link from npm to its public GitHub repository. The current profile now lists all six projects required by the current PWMKT-643 card, with a purpose line for each. The current card is narrower than the prior review's snapshot: maintainer notes and package metadata were explicitly moved to PWMKT-646, crm#15, rc-bridge#2, and FACT-1986, so the prior profile-only scope finding is resolved by the re-scope and is not re-raised here.
The first prior finding is resolved: gh repo view TurnWrk/shared --json isPrivate returned false, and the changed row now links to https://github.com/TurnWrk/shared with a description. The second prior finding is resolved against the current card scope: the card description now explicitly places maintainer notes and npm metadata in separate work items, while this PR's required org-profile outcome is complete.
Claim ledger:
- “Every link was checked: practical.works/call → 200; the practical-works-acropolis inngest-vps and claude-code-secret-guard repos → 200.” PASS. Re-running the URL checks on this tree returned
200 https://practical.works/book,200 https://github.com/practical-works-acropolis/inngest-vps, and200 https://github.com/practical-works-acropolis/claude-code-secret-guard. - “blog.practical.works and practical.works/blog are dead, so they were removed.” PASS for the changed surface: neither URL occurs in
profile/README.md, and the delta only adds the missing project row/corrects the guardrails link while retaining the prior removal. - “The guardrails description matches its README.” PASS by consistency with the public repository description: the profile describes shared git hooks, preserving user hooks, and secret-print protection;
gh repo view PracticalWorks/guardrailsis reachable. - “After merge, https://github.com/PracticalWorks shows the new profile, and every link in it opens.” UNVERIFIED-BY-DESIGN until the profile merge is live. The current tree's non-npm links returned HTTP 200; npmjs package URLs returned HTTP 403 from this environment rather than 404, so they are not dead-link evidence.
- CI: VERIFIED-BY-CI on exact head
514d8b21a9607484860d90edea476ea547585a18, run44020583343:guard-testsran script unit tests successfully, andguard / checkran PR-body and guardrails checks successfully.
The profile's required repo metadata is present: gh repo view reports non-empty descriptions, topics, and npm homepage URLs for both PracticalWorks/crm and PracticalWorks/rc-bridge.
REVIEW VERDICT: approve
REVIEWED DIFF: base=17ba766 files=1 lines=3
NEEDS VERIFICATION: After merge, https://github.com/PracticalWorks shows the new profile and every profile link opens.
Why
The org profile is the first thing a developer sees on github.com/PracticalWorks, and it was out of date:
What changed
profile/README.md:Proof
Verification
After merge, https://github.com/PracticalWorks shows the new profile, and every link in it opens: the five project links, the npm package pages, practical.works and practical.works/call.
Not in this PR
The card was re-scoped to this PR (the org profile, plus repo descriptions and topics). The maintainer note on every other public repo moved to PWMKT-646. Package metadata is covered by PracticalWorks/crm#15 (0.13.2, live), PracticalWorks/rc-bridge#2 (0.1.2, live) and FACT-1986 (guardrails 0.5.1, publishing from PracticalWorks/guardrails).
Refs: PWMKT-643
🤖 Generated with Claude Code