Skip to content

Implement document and workspace symbol providers for classes #3

Closed

Description

@daviwil

This requires an implementation of the DocumentSymbolProvider and WorkspaceSymbolProvider interfaces. Relevant code will need to be added to PowerShell Editor Services to support this behavior.

Activity

  1. added this to the 0.1.0 milestone on Nov 9, 2015
  2. changed the title [-]Add document and workspace symbol providers[/-] [+]Implement document and workspace symbol providers[/+] on Nov 9, 2015
  3. daviwil commented on Nov 9, 2015

    @daviwil
    ContributorAuthor

    Assigning Keith since this is for the feature he was interested in helping with. I'll provide more details privately.

  4. modified the milestones: 0.1.0, on Jan 2, 2016
  5. sgtoj commented on Sep 16, 2016

    @sgtoj

    Would this allow for symbols search and goto for PS 5.0's classes and enums?

  6. daviwil commented on Sep 16, 2016

    @daviwil
    ContributorAuthor

    Yep, that's something we haven't finished yet. Seems like you had commented on the Editor Services issue for this a while back:

    PowerShell/PowerShellEditorServices#14

    Sorry about that :/ I'll see if I can get some help to get that implemented for the 0.8.0 release!

  7. modified the milestones: 0.8.0, on Sep 16, 2016
  8. changed the title [-]Implement document and workspace symbol providers[/-] [+]Implement document and workspace symbol providers for classes[/+] on Sep 16, 2016
  9. 22 remaining items

  10. removed this from the milestone on Jan 26, 2021
  11. NonulliLester commented on Mar 14, 2022

    @NonulliLester

    Is this planned or being worked on?

  12. JustinGrote commented on Mar 14, 2022

    @JustinGrote
    Collaborator

    @lesterm5150 it's definitely noted as needed but the current highest priority is getting the extension stabilized with the new revamped internal engine to the point it's good for a stable release.

  13. Golosok commented on Nov 28, 2022

    @Golosok

    Any update or ETA?

  14. DougChandler commented on Jan 27, 2023

    @DougChandler

    Not sure if this been reported, but when editing a script that contains classes, the breadcrumb at the top of the script does not work for any class/method/enum.
    Since I use classes, this is very frustrating :(

  15. mpetr commented on Jan 27, 2023

    @mpetr

    as an heavy user of classes in all bigger projects, the ETA (or knowing any alternative approach) would be nice

  16. andyleejordan commented on Jan 27, 2023

    @andyleejordan
    Member

    This is landing in the next preview!!!

  17. andyleejordan commented on Feb 2, 2023

    @andyleejordan
    Member
  18. JustinGrote commented on Feb 7, 2023

    @JustinGrote
    Collaborator

    Andy Jordan (@andschwa) working great! I have about as complex of a class as it gets in ModuleFast, and methods aren't showing up for some reason for the most part, I think maybe because I implement IComparable and it's only picking up those base methods like Equals?

    https://github.com/JustinGrote/ModuleFast/blob/b531aa9ee95eb5941a064c9c0d0f2892e298db15/ModuleFast.psm1#L608-L620

    image
    image

    I have less complex classes that work fine and show all methods like NuGetRange
    image

    Let me know if this needs a new issue.

  19. andyleejordan commented on Feb 7, 2023

    @andyleejordan
    Member

    Justin Grote (@JustinGrote) I know it's confusing, but those three screenshots all look like completions which are handled via the PowerShell completion engine, so perhaps an issue there? After you've typed out the method name (with at least () so the PowerShell parser knows it's a method invocation) can you do "go-to definition" on it? And if you pull up the Outline view, do you see all your methods?

  20. SeeminglyScience commented on Feb 7, 2023

    @SeeminglyScience
    Collaborator

    Yeah there's typically nothing we can do in the extension to make new completions appear.

    That said, you might be hitting PowerShell/PowerShellEditorServices#1810 which is our problem. If it shows up after a Esc then Ctrl + Space then it's ours. If not, then you'd want to open in PowerShell/PowerShell

  21. JustinGrote commented on Feb 7, 2023

    @JustinGrote
    Collaborator

    Andy Jordan (@andschwa) Patrick Meinecke (@SeeminglyScience) oops I conflated two different things, you're right! Sorry about that, doing a quick symbol search and I'm seeing what I expect to see as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions