Repository navigation
Catch exceptions within completion handler - #1935
Merged
Andy Jordan (andyleejordan) merged 1 commit intoOct 24, 2022
Merged
Conversation
ghost
added
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/handle-failed-completions
branch
5 times, most recently
from
October 21, 2022 22:45
ade9d58 to
3f22ad4
Compare
Andy Jordan (andyleejordan)
enabled auto-merge (squash)
October 21, 2022 22:46
Patrick Meinecke (SeeminglyScience)
approved these changes
Oct 24, 2022
Patrick Meinecke (SeeminglyScience)
left a comment
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with one suggestion
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/handle-failed-completions
branch
2 times, most recently
from
October 24, 2022 21:38
620e2f4 to
0948131
Compare
We'll still see the same error in the log, but as a warning and not as an exception bubbled up over LSP that causes some clients, like Kate, to crash. We can't do anything about PowerShell's completion failing.
Andy Jordan (andyleejordan)
force-pushed
the
andschwa/handle-failed-completions
branch
from
October 24, 2022 22:49
0948131 to
fb62522
Compare
Andy Jordan (andyleejordan)
deleted the
andschwa/handle-failed-completions
branch
October 24, 2022 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'll still see the same error in the log, but as a warning and not as an exception bubbled up over LSP that causes some clients, like Kate, to crash. We can't do anything about PowerShell's completion failing.
Fixes #1926.