Repository navigation
Fix legacy CI - #1103
Merged
Merged
Fix legacy CI#1103
Conversation
TylerLeonhardt
marked this pull request as ready for review
November 13, 2019 18:03
Christoph Bergmeister (bergmeister)
approved these changes
Nov 13, 2019
Christoph Bergmeister (bergmeister)
left a comment
Christoph Bergmeister (bergmeister)
left a comment
Contributor
There was a problem hiding this comment.
This is awesome, I've wanted to make such a change for a while for the legacy branch because I always needed to add a global.json because the build didn't work with the .net core 3 sdk. I am surprised it works though because when I was in the middle of doing that change, the tests didn't work due to the old xunit test runner being deprecated for .net core 2.1 so I guess someone backported the testing improvements from master...
At the end all that counts is that it works though :)
Rob Holt (rjmholt)
approved these changes
Nov 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.