Repository navigation
Fix diagnostics not showing in untitled files and now also show CodeLens - #1098
Merged
TylerLeonhardt merged 2 commits intoNov 13, 2019
Merged
TylerLeonhardt merged 2 commits into
TylerLeonhardt merged 2 commits into
Conversation
Rob Holt (rjmholt)
approved these changes
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes PowerShell/vscode-powershell#2290
It's both a fix (Diagnostics showing up in Untitled files again)
and a feature (CodeLens showing up in Untitled files now)
It does ask a greater question of - can
scriptFiles have a reference to theirUriobject now since O# does an awesome job at giving us theUris for files already.Also I feel like the tests might have covered this regression... I really need to sit down and bring those back.