Skip to content

Backport #1023 and #1021 - #1024

Merged
TylerLeonhardt merged 3 commits into
PowerShell:legacy/1.xfrom
rjmholt:backport/1021
Sep 17, 2019
Merged

TylerLeonhardt merged 3 commits into
PowerShell:legacy/1.xfrom
rjmholt:backport/1021

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Sep 10, 2019 •

Copy link
Copy Markdown
Contributor

Backport #1023 and #1021

…) to add support for optionally correcting aliases as well (added in PSSA 1.18.2) (PowerShell#1021)
@rjmholt Rob Holt (rjmholt) changed the title Backport/1021 Backport #1023 and #1021 Sep 10, 2019

@TylerLeonhardt TylerLeonhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TylerLeonhardt

Copy link
Copy Markdown
Member

I've added Christoph Bergmeister (@bergmeister) to the list of reviewers - I wouldn't block if he doesn't sign off in time though. This LGTM

@TylerLeonhardt

Copy link
Copy Markdown
Member

also update to 1.18.3 when that goes out

Comment thread modules.json
{
"PSScriptAnalyzer":{
"MinimumVersion":"1.6",
"MinimumVersion":"1.18.2",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"MinimumVersion":"1.18.2",
"MinimumVersion":"1.18.3",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change this later.

@TylerLeonhardt
TylerLeonhardt merged commit 4710355 into PowerShell:legacy/1.x Sep 17, 2019
@rjmholt
Rob Holt (rjmholt) deleted the backport/1021 branch December 11, 2019 21:41
TylerLeonhardt pushed a commit that referenced this pull request Jan 8, 2020
…t got broken in #1024 (#1142)

* Fix PipelineIndentation configuration issue (#1050)

* legacy/1.x: Update minimum PSSA version to 1.18.3 (#1052)

* Fix wiring of WhitespaceInsideBrace and WhitespaceAroundPipe

* revert regression from master

* add trailing comma

* revert PSAvoidUsingCmdletAliases change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants