Skip to content

Re-enable Console/ChoicePromptHandlerTests.cs #1440

New issue
New issue
Closed
#1660
Closed
Re-enable Console/ChoicePromptHandlerTests.cs#1440
#1660
Assignees
andyleejordan
Labels
Area-TestIssue-BugA bug to squash.

Description

@andyleejordan
Andy Jordan (andyleejordan)
opened on Mar 29, 2021

Two of this file's three tests are skipped:

PowerShellEditorServices/test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cs

Lines 27 to 28 in d54bda7

[Fact(Skip = "This test fails often and is not designed well...")]
public void ChoicePromptReturnsCorrectIdForChoice()

PowerShellEditorServices/test/PowerShellEditorServices.Test/Console/ChoicePromptHandlerTests.cs

Lines 50 to 51 in d54bda7

[Fact(Skip = "Hotkeys are not exposed while VSCode ignores them")]
public void ChoicePromptReturnsCorrectIdForHotKey()

Activity

  1. Andy Jordan (andyleejordan)
    added
    Area-Test
    on Mar 29, 2021
  2. Andy Jordan (andyleejordan)
    self-assigned this
    on Mar 29, 2021
  3. Andy Jordan (andyleejordan)
    changed the title [-]Fix skipped tests in `Console/ChoicePromptHandlerTests.cs`[/-] [+]Fix skipped tests in `ChoicePromptHandlerTests.cs`[/+] on Mar 29, 2021
  4. Andy Jordan (andyleejordan)
    changed the title [-]Fix skipped tests in `ChoicePromptHandlerTests.cs`[/-] [+]Fix skipped tests in `Console/ChoicePromptHandlerTests.cs`[/+] on Mar 29, 2021
  5. Andy Jordan (andyleejordan)
    removed their assignment
    on Mar 29, 2021
  6. Andy Jordan (andyleejordan)
    changed the title [-]Fix skipped tests in `Console/ChoicePromptHandlerTests.cs`[/-] [+]Re-enable `Console/ChoicePromptHandlerTests.cs`[/+] on Jan 5, 2022
  7. Andy Jordan (andyleejordan)
    self-assigned this
    on Jan 5, 2022
  8. Andy Jordan (andyleejordan)
    added
    Issue-BugA bug to squash.
    on Jan 5, 2022

  9. andyleejordan commented on Jan 5, 2022

    @andyleejordan
    Andy Jordan (andyleejordan)
    on Jan 5, 2022
    MemberAuthor

    These are actually now all disabled.

  10. ghost added
    Status: In PR
    on Jan 11, 2022
  11. Andy Jordan (andyleejordan)
    closed this as completedin #1660on Jan 11, 2022
  12. ghost removed
    Status: In PR
    on Jan 11, 2022
  13. ghost added
    Status: Fixed
    on Jan 11, 2022
  14. Andy Jordan (andyleejordan)
    added this to Sea Biscuiton Jan 24, 2022
  15. Andy Jordan (andyleejordan)
    moved this to Todo in Sea Biscuiton Jan 24, 2022
  16. Andy Jordan (andyleejordan)
    moved this from Todo to Done in Sea Biscuiton Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Area-TestIssue-BugA bug to squash.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions