Repository navigation
ModuleHelp.Tests.ps1 throws false positives #1417
Description
There are small problems in the ModuleHelp.Tests.ps1 file when running tests on Pwsh, or running on an environment without PSScriptAnalyzer actually installed.
affected areas:
- test failure when PSScriptAnalyzer is not installed (only loaded from the .\out\ directory)
- test failure on Pwsh due to non-supported 'Workspace' command type
Steps to reproduce
- on a system without PSScriptAnalyzer module installed
- when build configuration is set to DEBUG
.\PSScriptAnalyzer\build.ps1
.\PSScriptAnalyzer\build.ps1 -TestExpected behavior
- No test failures
- No test failures
Actual behavior
- Test fails to properly check module version, because it was not installed, only loaded from
.\PSScriptAnalyzer\out\ - Test fails with an error that the 'AttachAndDebug' parameter for Invoke-ScriptAnalyzer and Invoke-Formatter does not have Help.
Activity
SydneyhSmith commentedon Feb 25, 2020
Jos Koelewijn (@Jawz84) thanks for opening this issue and linking the PR
fix #1417 modulehelp false positives (#1418)
bergmeister commentedon Feb 25, 2020
Yes, thanks, I've merged it in now. I've changed the labels though from bug to build as this is not a bug in the actual product but rather the internal build/test system
Jawz84 commentedon Feb 25, 2020
Thanks for taking the time to write that, I understand you had to try a few times and do it from mobile because it wouldn't work from desktop 👍
bergmeister commentedon Feb 25, 2020
No worries, that problem I mentioned on Twitter earlier applied to this much bigger comment actually (where I decide to just copy paste the text into a draft email to be able to copy paste from my mobile...) 😅 Commenting works now again from Desktop :-) I've seen some of the updates in your other PR and want to take some time this week to fully review it but from a glance it looks already good