Repository navigation
Wrong indentation for passed scriptblocks in pipe sequence (PSUseConsistentIndentation) #1066
Description
Steps to reproduce
Get-ChildItem *.yml |
Get-Content -Raw |
ConvertFrom-KubeYaml |
ForEach-Object {
switch ($_.Metadata.Name) {
# ...
}
} |
Update-KubeResourceExpected behavior
Should not cause a rule violation, this is the expected formatting
Actual behavior
Formats to:
Get-ChildItem *.yml |
Get-Content -Raw |
ConvertFrom-KubeYaml |
ForEach-Object {
switch ($_.Metadata.Name) {
# ...
}
} |
Update-KubeResourceNote how the switch is not indented and the closing brace of the scriptblock is on the wrong level, while the next pipeline element is correct.
Environment data
> $PSVersionTable
Name Value
---- -----
PSVersion 6.1.0-rc.1
PSEdition Core
GitCommitId 6.1.0-rc.1
OS Darwin 17.7.0 Darwin Kernel Version 17.7.0: Thu Jun 21 22:53:14 PDT 2018; root:xnu-4570.71.2~1/RELEASE_X86_64
Platform Unix
PSCompatibleVersions {1.0, 2.0, 3.0, 4.0...}
PSRemotingProtocolVersion 2.3
SerializationVersion 1.1.0.1
WSManStackVersion 3.0
> (Get-Module -ListAvailable PSScriptAnalyzer).Version | ForEach-Object { $_.ToString() }
1.17.1
Activity
bergmeister commentedon Nov 5, 2018
Thanks for raising it and sorry for coming back quite late to this. This has annoyed me sometimes as well. I will start to look into this so that we hopefully have a fix in the next version of PSSA
bergmeister commentedon Nov 14, 2018
I had a look at this, a slightly more simplified example for this issue is (the problem is that there is more than 1 line after 1 pipeline)
I will try to see if I can come up with a fix for this, as far as I can see, pipes are being catered for but the author decided to give them only 'temporary' indentation for the next line after the ppipe because the rule only looks at tokens and therefore does not know when the pipe ends. I will try to see if I can fix this.
Felix Becker (@felixfbecker) Why do you not expect the correct formatting to be this?