Skip to content

Allow wildcard for MAR repository for FindAll and FindByName - #1786

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:WildCardACR
Feb 19, 2025
Merged

Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:WildCardACR

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Jan 28, 2025 •

Copy link
Copy Markdown
Member

PR Summary

This pull request to src/code/ContainerRegistryServerAPICalls.cs includes changes to enhance the functionality of finding packages in a container registry and improve the test coverage for the MAR repository. The most important changes include adding a new URL template for listing repositories, modifying the FindAll and FindNameGlobbing methods to use the new FindPackages helper method, and adding new tests for wildcard searches.

Enhancements to finding packages:

  • Added a new URL template containerRegistryRepositoryListTemplate for listing repositories.
  • Modified the FindAll method to use the new FindPackages helper method instead of returning an error.
  • Modified the FindNameGlobbing method to use the new FindPackages helper method instead of returning an error.
  • Added a new helper method FindAllRepositories to list all repositories in the container registry.
  • Added a new helper method FindPackages to find packages using wildcards and handle MAR-specific logic.

Improvements to test coverage:

  • Added new tests to verify finding resources with wildcards in their names and finding all resources in the MAR repository.

PR Context

PR Checklist

Comment thread src/code/ContainerRegistryServerAPICalls.cs Outdated
Comment thread src/code/ContainerRegistryServerAPICalls.cs Outdated

@anamnavi Anam Navied (anamnavi) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some feedback, but overall looks good!

Co-authored-by: Anam Navied <anam.naviyou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants