Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions PSReadLine/Position.cs
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,17 @@ public partial class PSConsoleReadLine
/// <param name="current">The position in the current logical line.</param>
private static int GetBeginningOfLinePos(int current)
{
var newCurrent = current;

if (_singleton.LineIsMultiLine())
int i = Math.Max(0, current);
while (i > 0)
{
int i = Math.Max(0, current);
while (i > 0)
if (_singleton._buffer[--i] == '\n')
{
if (_singleton._buffer[--i] == '\n')
{
i += 1;
break;
}
i += 1;
break;
}

newCurrent = i;
}
else
{
newCurrent = 0;
}

return newCurrent;
return i;
Comment thread
springcomp marked this conversation as resolved.
Resolved
}

/// <summary>
Expand Down Expand Up @@ -114,7 +103,7 @@ private static int GetFirstNonBlankOfLogicalLinePos(int current)

var newCurrent = beginningOfLine;

while (IsVisibleBlank(newCurrent))
while (newCurrent < _singleton._buffer.Length && IsVisibleBlank(newCurrent))
{
newCurrent++;
}
Expand Down
10 changes: 10 additions & 0 deletions test/MovementTest.VI.Multiline.cs
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,16 @@ public void ViMoveToFirstNonBlankOfLogicalLine_NoOp_OnEmptyLine()
));
}

[SkippableFact]
public void ViDefect2050()
{
TestSetup(KeyMode.Vi);

Test("", Keys(
_.Escape, _.Underbar
));
}

[SkippableFact]
public void ViMoveToEndOfLine_NoOp_OnEmptyLine()
{
Expand Down