Repository navigation
Remove LineIsMultiline in favor of multiline agnostic algorithms (#1125) - #2047
Merged
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested changes
Jan 8, 2021
Dongbo Wang (daxian-dbw)
left a comment
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
Thanks for taking the time to elide the unneeded LineIsMultiLine() check. I left a few comments.
ghost
added
the 
Maxime Labelle (springcomp)
force-pushed
the
#1125
branch
2 times, most recently
from
January 19, 2021 14:29
ce03db3 to
da1faa9
Compare
5 tasks done
Dongbo Wang (daxian-dbw)
force-pushed
the
#1125
branch
from
February 10, 2021 18:29
80e4226 to
0f2a6fa
Compare
Member
|
Maxime Labelle (@springcomp) I apologize for taking so long to get back to this. |
Contributor
Author
|
No worries. I will address the changes. |
Dongbo Wang (daxian-dbw)
approved these changes
Feb 11, 2021
Dongbo Wang (daxian-dbw)
left a comment
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks Maxime Labelle (@springcomp)!
|
🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #1125.
This PR removes as many calls as possible of the method
LineIsMultiline()where the underlying algorithm is already behaving consistently irrespective of the number of logical lines in the buffer.PR Checklist
Microsoft Reviewers: Open in CodeFlow