PSReadine doesnt clear multiline text when Escape pressed #607

Activity

1. lzybkr commented on Dec 8, 2017

   

   Jason Shirk (lzybkr)

   on Dec 8, 2017

   Contributor

   More actions

   Strange, I've been self hosting for months and should have noticed this. It will be a few days before I can take a look.
2. MVKozlov commented on Dec 9, 2017

   

   Max Kozlov (MVKozlov)

   on Dec 9, 2017

   Last edited by MVKozlov

   ContributorAuthor

   More actions

   Tested on another WIn7, same effect
   on Win10 all ok
3. MVKozlov commented on Dec 11, 2017

   

   Max Kozlov (MVKozlov)

   on Dec 11, 2017

   ContributorAuthor

   More actions

   I addition: Powershell shutdown/unload time on 2.0 up to 6-7 sec :(
4. lzybkr commented on Dec 11, 2017

   

   Jason Shirk (lzybkr)

   on Dec 11, 2017

   Contributor

   More actions

   Please open another issue and include some details like how you close PowerShell and the versions of Windows and PowerShell where you see this behavior.
5. lzybkr commented on Dec 17, 2017

   

   Jason Shirk (lzybkr)

   on Dec 17, 2017

   Contributor

   More actions

   I have reproduced the problem on Win7 as well as Win10 in legacy mode.

   There is a difference in how conhost handles Console.WriteLine() when at the end of the line. I'll think more about a fix - and hopefully this difference doesn't come up elsewhere - I think it came up in menu completion (which is fixed now) but I don't think the same fix will work here.
6. Jason Shirk (lzybkr)

   added this to the 2.0.0-beta2 milestone on Mar 20, 2018
7. Jason Shirk (lzybkr)

   modified the milestones: 2.0.0-beta2, 2.0.0-beta3 on Jun 4, 2018
8. MVKozlov commented on Nov 6, 2018

   

   Max Kozlov (MVKozlov)

   on Nov 6, 2018

   ContributorAuthor

   More actions

   Back to old problem :)
   this diff fixes rendering on win7 and I do not see any difference of WinSrv2016. It doesn't break anything (I try to check it on Win10 later)

   Do not try any Linuxes, may be it need to tune up

   --- Render~orig.cs      Tue Nov 06 11:49:37 2018
   +++ Render.cs   Tue Nov 06 11:48:58 2018
   @@ -486,7 +486,7 @@
   
                while (previousPhysicalLine > physicalLine)
                {
   -                _console.Write("\n");
   +                //_console.Write("\n");
                    physicalLine += 1;
                    var lenToClear = physicalLine == previousPhysicalLine ? lenPrevLastLine : bufferWidth;
                    if (lenToClear > 0)

   May be I don't uderstand something but it just works :O
9. lzybkr commented on Nov 6, 2018

   

   Jason Shirk (lzybkr)

   on Nov 6, 2018

   Contributor

   More actions

   Feel free to submit a PR.
10. MVKozlov commented on Nov 7, 2018

    

    Max Kozlov (MVKozlov)

    on Nov 7, 2018

    ContributorAuthor

    More actions

    I'll wait until I'm at least understand what this code should do and test it on win10/linuxes :)
11. s-shamesmuhametov-parc commented on Mar 4, 2019

    

    Шамесмухаметов Святослав (s-shamesmuhametov-parc)

    on Mar 4, 2019

    More actions

    It also reproduced on my Windows 8.1. When I navigate through my history containing multi-line commands
    Commenting line _console.Write("\n"); helps. Thanks Max Kozlov (@MVKozlov)
    It would be good to fix it PR
12. Dongbo Wang (daxian-dbw)

    modified the milestones: 2.0.0-beta3, Future on Jul 15, 2019
13. Dongbo Wang (daxian-dbw)

    removed this from the 2.1.0-Consider milestone on Sep 22, 2021
14. daxian-dbw commented on Apr 28, 2023

    

    Dongbo Wang (daxian-dbw)

    on Apr 28, 2023

    Member

    More actions

    I cannot reproduce this anymore on Windows Server 2012R2 (legacy mode), so it should have been fixed.
15. Dongbo Wang (daxian-dbw)

    closed this as completedon Apr 28, 2023