You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Port PSReadLine project to compile on .NET Core #498
I'm trying to work out a solution where I can generate 1 binary that works on all platforms to avoid shipping 3 binaries (Linux, Windows Core, Windows Full) - like what is happening today with PackageManagement.
You might talk with David Wilson (@daviwil) if you haven't already. He just did this for the PowerShellEditorServices. It all builds from within VS Code.
Right now I'm hitting https://github.com/dotnet/corefx/issues/9658
I might have a sort of workaround to target the netstandard1.6 version of the System.Management.Automation reference assembly, but that could cause problems targeting older versions of PowerShell, e.g. if we use an api that wasn't in V3.
Activity
lzybkr commentedon Jan 27, 2017
This is wip, see #442
I'm trying to work out a solution where I can generate 1 binary that works on all platforms to avoid shipping 3 binaries (Linux, Windows Core, Windows Full) - like what is happening today with PackageManagement.
lzybkr commentedon Jan 27, 2017
I should mention - I have more changes on top of that PR that I haven't pushed yet because it's not ready.
rkeithhill commentedon Jan 27, 2017
You might talk with David Wilson (@daviwil) if you haven't already. He just did this for the PowerShellEditorServices. It all builds from within VS Code.
PS. Glad to hear that work is under way. Cool!
lzybkr commentedon Jan 27, 2017
Right now I'm hitting https://github.com/dotnet/corefx/issues/9658
I might have a sort of workaround to target the netstandard1.6 version of the System.Management.Automation reference assembly, but that could cause problems targeting older versions of PowerShell, e.g. if we use an api that wasn't in V3.
daviwil commentedon Jan 28, 2017
Weird, I use Hashtable in a couple places in PSES and I'm building against netstandard1.6 just fine:
https://github.com/PowerShell/PowerShellEditorServices/blob/2c7709bfe2748e9c832a9488e17010e63c71fb28/src/PowerShellEditorServices/Session/PowerShellVersionDetails.cs#L103
I'm building against the Microsoft.PowerShell.SDK package on MyGet:
https://powershell.myget.org/feed/powershell-core/package/nuget/Microsoft.PowerShell.SDK
I'm also using the v3-v5 reference assemblies to verify that my code builds against the older apis:
lzybkr commentedon Oct 17, 2017
With
netstandard2, this isn't strictly necessary anymore. That doesn't mean I won't make the change, but it is less compelling right now.I'm closing so I have fewer open issues - we can revisit later if it really matters.