Skip to content

Enable prompt to show prediction #3525

Open

Description

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

An implementation of both IFeedbackProvider and ICommandPredictor can benefit just showing the prediction at the prompt before a keypress. I realize that PSReadLine is only invoked upon a keypress, so this may require changes to PS7 as well to make this work. We may want to special case it some most predictions still work against key presses.

Proposed technical implementation details (optional)

No response

Activity

  1. ghost added
    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.
    on Dec 27, 2022
  2. added
    Area-PredictorsLabel for issues related to predictors
    and removed
    Needs-Triage 🔍It's a new issue that core contributor team needs to triage.
    on Jan 4, 2023
  3. moved this from Needed by 7.4 GA to Investigation Tasks in Feedback Provider Roadmapon May 23, 2023
  4. StevenBucher98 commented on May 30, 2023

    @StevenBucher98
    Collaborator

    Here are mock ups for the experiences when feedback providers give prediction results:

    Inline view

    • (If possible) Predictors will only chose the top most feedback provider to show only after feedback providers have been triggered in some way (is this possible in PSReadLine?)

    Screenshot 2023-05-25 at 9 34 39 AM

    • Otherwise if no feedback provider has been trigger then don't show anything until characters are typed (experience now)

    ListView

    • ListView will order the prediction sources based on order of feedback providers (import order)
    image
    • as user begins typing in ListView then history will take higher priority but still will be present

    Screenshot 2023-05-25 at 11 17 18 AM

    • If the user has plugin predictors also enabled and only after a feedback provider trigger, then the feedback provider predictor results will be higher in the order
    image

    cc Dongbo Wang (@daxian-dbw)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions