Repository navigation
Make predictions not show invalid paths #3380
Description
Prerequisites
- Write a descriptive title.
Description of the new feature/enhancement
When using the new prediction, it would be nice if incorrect paths were not presented as suggestions, at least for well-known/default cmdlets like Set-Location, Get-ChildItem and so on
Proposed technical implementation details (optional)
No response
Activity
[-]Make predictions aware of current path[/-][+]Make predictions not show invalid paths[/+]StevenBucher98 commentedon Jan 4, 2023
Renato Golia (@Kralizek) which predictors were you using that were presenting incorrect paths? If you have an example of this behavior currently that would be helpful!
Kralizek commentedon Jan 4, 2023
Steven Bucher (@StevenBucher98)
The problem I have been experiencing can be summarized as follows:
If i have a directory tree first\second\third
If I do
When I'm in first, if i start typing "cd", I get "first" suggested even if it's not a valid input.
(Sorry for the formatting, I saw the notification just when I had turned off the PC)
StevenBucher98 commentedon Jan 4, 2023
Got it thanks Renato Golia (@Kralizek) for clarification! Currently that is the expected behavior since last in your history is the
cd firstbut we are looking at adding to history predictors in the future, related issue #3472Kralizek commentedon Jan 4, 2023
Steven Bucher (@StevenBucher98) I didn't know of that issue. Ideally a predictor could also try to suggest new values that are valid in any given context.
In this case, it would be cool if
secondwas a value considered for prediction.daxian-dbw commentedon Mar 28, 2023
Renato Golia (@Kralizek) I think what you want is prediction from the results of tab completion -- prediction result should be shown for
cd .just like you press Tab. If my understanding is correct, then this issue should be migrated to https://github.com/PowerShell/CompletionPredictor.[Update] Reading through the comments again, and I guess your concern is more about the history predictions should be filtered more smartly (
cd firstcame from the history). Then we should keep this issue in this repo.Kralizek commentedon Mar 28, 2023
Your updated comment is correct.
daxian-dbw commentedon Mar 28, 2023
Be noted that, even if the history prediction is filtered more smartly, you won't see
cd secondas the prediction for the above scenario, becuase it's not yet available in the history.Kralizek commentedon Mar 29, 2023
It makes sense and fine with not having wrong suggestions :)