Investigate perf gain by using the .NET char comparison pattern #1915

Activity

1. Dongbo Wang (daxian-dbw)

   added

   Issue-EnhancementIt's a feature request.It's a feature request.

   on Oct 30, 2020
2. ghost added

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Oct 30, 2020
3. iSazonov commented on Oct 30, 2020

   

   Ilya (iSazonov)

   on Oct 30, 2020

   More actions

   Do you want to measure only LengthInBufferCells() method?
   I could measure and share results if you want.
4. daxian-dbw commented on Oct 30, 2020

   

   Dongbo Wang (daxian-dbw)

   on Oct 30, 2020

   MemberAuthor

   More actions

   Yup, measuring only the LengthInBufferCells() would be enough. Thanks!

   👍React with 👍1Reacted by Ilya
5. Dongbo Wang (daxian-dbw)

   added

   Not-Planned

   and removed

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Oct 30, 2020
6. iSazonov commented on Oct 31, 2020

   

   Ilya (iSazonov)

   on Oct 31, 2020

   More actions

   In my test the worst case (char is in last range) is improved up to 16%. Thoughts?

   BenchmarkDotNet=v0.12.1, OS=Windows 10.0.18362.1082 (1903/May2019Update/19H1)
   Intel Core i5-2410M CPU 2.30GHz (Sandy Bridge), 1 CPU, 4 logical and 2 physical cores
   .NET Core SDK=5.0.100-rc.2.20479.15
     [Host]     : .NET Core 5.0.0 (CoreCLR 5.0.20.47505, CoreFX 5.0.20.47505), X64 RyuJIT
     DefaultJob : .NET Core 5.0.0 (CoreCLR 5.0.20.47505, CoreFX 5.0.20.47505), X64 RyuJIT
   
   

   Method	InputString	Mean	Error	StdDev	Ratio	Gen 0	Gen 1	Gen 2	Allocated	Code Size
   LengthOrig	ï¿¡	8.059 ns	0.0812 ns	0.0759 ns	1.00	-	-	-	-	251 B
   LengthNew	ï¿¡	6.757 ns	0.0846 ns	0.0791 ns	0.84	-	-	-	-	206 B