System.ArgumentOutOfRangeException PSReadLine: 2.1.0-beta1 PowerShell: 7.1.0-preview.2 #1495

Activity

1. ghost added

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on Apr 30, 2020
2. iSazonov commented on Apr 30, 2020

   

   Ilya (iSazonov)

   on Apr 30, 2020

   Last edited by iSazonov

   More actions

   Investigating...

   Yes, please.

   See also #1469
3. lzybkr commented on Apr 30, 2020

   

   Jason Shirk (lzybkr)

   on Apr 30, 2020

   Contributor

   More actions

   I'm guessing this will be hard to reproduce.

   Here are some useful details that may help:

   • After you type Enter, the command you entered and the undo stack is saved in memory - just the command line is saved in your history file.
   • When you recall a previous command with editing history (UpArrow), you can undo (e.g. Ctrl+z) immediately.
   • Esc actually uses the undo stack.
4. daxian-dbw commented on May 1, 2020

   

   Dongbo Wang (daxian-dbw)

   on May 1, 2020

   Member

   More actions

   I found the issue and also the consistent repro:

   1. in Windows edit mode, run Set-PSReadLineKeyHandler -Chord "Ctrl+f" -Function ForwardWord
   2. Type git checkout -b blah origin/nonexist and press Enter
   3. Type git ch, and press Ctrl+f, then press Enter
   4. Press UpArrow, then press Escape

   The issue will be fixed in #1496 (the 2nd commit).

   👍React with 👍3Reacted by Ilya, Daniel Ferreira and Mavaddat Javid
5. daxian-dbw commented on May 1, 2020

   

   Dongbo Wang (daxian-dbw)

   on May 1, 2020

   Member

   More actions

   From Daniel Ferreira (@daniel0x00)

   I see the same on PSReadLine 2.1.0-beta1:

   Environment

   PSReadLine: 2.1.0-beta1
   PowerShell: 7.0.0
   OS: Microsoft Windows 10.0.17763
   Last 200 Keys

   Ctrl+Backspace Backspace Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow >Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow Ctrl+LeftArrow $ redactedobject Spacebar = Spacebar Enter
   $ redactedobject Spacebar = Spacebar $ redactedobject . a r g s Enter
   $ redactedobject  Spacebar = Spacebar $ redactedobject  Spacebar | Spacebar s e l e c t Spacebar * , Spacebar @ { n = ' c o m m a n d ' ; e = { $ redactedobject  } } , Spacebar @ { n = ' >REDACTED ' ; e = { $ e n v : C O M P U T E R N A M E } } Enter
   Enter
   $ redactedobject Enter
   Enter
   UpArrow UpArrow UpArrow DownArrow DownArrow UpArrow UpArrow UpArrow Escape
   

   Exception

   System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')
     at System.Text.StringBuilder.Insert(Int32 index, String value)
     at Microsoft.PowerShell.PSConsoleReadLine.EditItemDelete.Undo()
     at Microsoft.PowerShell.PSConsoleReadLine.RevertLine(Nullable`1 key, Object arg)
     at Microsoft.PowerShell.PSConsoleReadLine.ProcessOneKey(PSKeyInfo key, Dictionary`2 dispatchTable, Boolean ignoreIfNoAction, Object arg)
     at Microsoft.PowerShell.PSConsoleReadLine.InputLoop()
     at Microsoft.PowerShell.PSConsoleReadLine.ReadLine(Runspace runspace, EngineIntrinsics engineIntrinsics, CancellationToken cancellationToken)
   
6. daxian-dbw commented on May 1, 2020

   

   Dongbo Wang (daxian-dbw)

   on May 1, 2020

   Member

   More actions

   From James O'Neill (@jhoneill)

   Another one here. Identical stack trace displayed to Daniel Ferreira (@daniel0x00) above.
   It seems to be be fairly common and easy to repro in VS Code integrated shell

   Put in a long line at the last line in the window, press [ESC] and POW! Something seems to do its sums wrongly and think it should be removing stuff from a line after the end of the window.
   If I move the cursor to left of about 176 (even if the line is very long) all is OK. If I'm not on the last line, all is OK. but cursor to near the bottom right is what triggers it . Whilst very ugly it doesn't do any real harm apart from displaying the error the session seems unaffected

   PS version: 7.0.0
   PSReadline version: 2.1.0-beta1'; ProjectUri = 'https://github.com/PowerShell/PSReadLine
   os: 10.0.18362.1 (WinBuild.160101.0800)
   PS file version: 7.0.0.0
   HostName: Visual Studio Code Host
   BufferWidth: 220
   BufferHeight: 32
   
7. Dongbo Wang (daxian-dbw)

   added

   Issue-BugIt either shouldn't be doing this or needs an investigation.It either shouldn't be doing this or needs an investigation.

   and removed

   Needs-Triage 🔍It's a new issue that core contributor team needs to triage.It's a new issue that core contributor team needs to triage.

   on May 1, 2020
8. Dongbo Wang (daxian-dbw)

   closed this as completedin #1496on May 9, 2020